Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for pycoverm #52919

Closed
wants to merge 7 commits into from
Closed

Conversation

prototaxites
Copy link
Contributor

Adds a recipe for pycoverm - required for #43684


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@mbhall88
Copy link
Contributor

Pinging @apcamargo as this is your library and maybe @luizirber as you are the master with Maturin stuff evidently.

The error doesn't make a lot of sense

The following metadata fields in `package.metadata.maturin` section of Cargo.toml are removed since maturin 0.14.0: requires-dist, please set them in pyproject.toml as PEP 621 specifies.

but there is no maturin metadata section defined in the Cargo.toml so not sure what is up here?

@prototaxites
Copy link
Contributor Author

I think the version hosted on PyPI needs an older version of maturin - the Cargo.toml file hosted there has the following section:

[package.metadata.maturin]
requires-dist = ["numpy"]

and the pyproject.toml states requires = ["maturin>=0.10,<0.11"].

I thought it best to build from the PyPI release, but maybe it's better to build from the latest GitHub?

@mbhall88
Copy link
Contributor

Ohhh I totally missed that. There’s no GitHub releases tagged so we’ll have to keep pypi. Maybe @apcamargo can mint a new release with updated maturin etc.? (Matching the work done for the needletail package with the pyO3 specification?)

@mbhall88
Copy link
Contributor

Closing in favour of #52941

@mbhall88 mbhall88 closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants