Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openms: add r-gplots requirement #32788

Closed

Conversation

bernt-matthias
Copy link
Contributor

used in MetaProSIP

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@timosachsenberg
Copy link
Contributor

can you add Julianus as reviewer?

@bernt-matthias
Copy link
Contributor Author

I can't select him in the list. Maybe a ping @jpfeuffer does the trick?

@jpfeuffer
Copy link
Contributor

Fine with me, if you can make it build successfully. Not sure if the package conflicts or if there was just a misspelling somewhere.

@jpfeuffer
Copy link
Contributor

@bernt-matthias @timosachsenberg Do you mean "r-gplots" instead of "r-gplot"?

@jpfeuffer
Copy link
Contributor

I will add it to #33351 if you confirm

@timosachsenberg
Copy link
Contributor

in the R code it is called "library(gplots)"

jpfeuffer added a commit to jpfeuffer/bioconda-recipes that referenced this pull request Feb 25, 2022
@jpfeuffer
Copy link
Contributor

superseded by #33351

@bernt-matthias
Copy link
Contributor Author

Thanks @jpfeuffer

bgruening pushed a commit that referenced this pull request Feb 27, 2022
* adapt nightlies to 2.8 dev cycle

* fix patch for new code

* remove all patches. not needed anymore

* change boost finding and enable debug for it

* was it the comments???

* bump autowrap

* Add dependencies to libopenms again. Problems after install

* Bump build number to check

* Added back all dependencies to openms bins as well

* try to separate openms and pyopenms

* cleanp

* contrib path?

* braces

* parent

* use SRCDIR

* hardcode openms version

* change version

* add conda config to ignore py2 and have same compiler

* use new cmake install components for installing

* need cmake to run cmake install

* add some more deps to pyopensm

* use no_dependencies in pyopenms

* remove . before dev version

* remove . before dev version

* add equals to version dep?

* well specify without ninja variable

* forgot to install

* Update meta.yaml

* Path to wheel

* Update build.sh

* remove newlines

* cleanup

* switch from nightly to release

* reset build number and limit builds

* forgot to save

* remove pyopenms since bioconda cannot figure out dependencies

* do not specify versions of pinned packages?

I thought I would do the ridiculously slow solver a favor.. but conda is just full of bugs

* add gplots, see  #32788
@bernt-matthias bernt-matthias deleted the topic/openms-r-gplot branch March 14, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants