refactor: use importlib instead of pkg_resources #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, this PR (and others) is intended to support progress on biocommons/biocommons.example#42 |
|
Oh, this won't work on 3.8 -- for transitioning up to 3.10-3.12, should we first wrap this up in try/except blocks, and then remove when the 3.10-3.12 PR comes through? |
korikuzma
approved these changes
May 23, 2024
|
actually, I must've been mistaken, because it definitely works in 3.8 (looks like importlib.resources was added in 3.7) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
importlib.resources.files(__package__)to get to_data. I think, from reading (https://discuss.python.org/t/easy-and-recommended-way-to-get-path-of-datafile-within-package/20581/4) and (https://stackoverflow.com/questions/6028000/how-to-read-a-static-file-from-inside-a-python-package/58941536) that this is the best way forward.