Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix dynamic dependencies for newer setuptools versions #133

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

jsstevenson
Copy link
Contributor

1-for-1 mirroring of @andreasprlic PR on HGVS: biocommons/hgvs#713

FWIW, more and more Python tools support configuration in pyproject.toml, might be nice to consolidate the rest of the setuptools configs in setup.cfg + some of the other files (pytest.ini, etc)

@jsstevenson jsstevenson requested a review from reece as a code owner January 18, 2024 18:21
Copy link
Member

@andreasprlic andreasprlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jsstevenson jsstevenson merged commit 5fadcfc into main Jan 19, 2024
7 checks passed
@jsstevenson jsstevenson deleted the fix-setuptools-install branch January 19, 2024 13:15
@reece
Copy link
Member

reece commented Jan 29, 2024

@jsstevenson You may know this already... Please use biocommons.example as the template for all repos. I typically make changes there and merge with meld (or other visual merge tool) into all of the other repos.

@jsstevenson
Copy link
Contributor Author

Good point @reece -- I was sort of on hotfix mode on this one and didn't think to check if a divergence from the template might be the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants