Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement attributes for GenStruct and GenEnum #87

Merged

Conversation

NightEule5
Copy link
Contributor

Fixes #79

@NightEule5 NightEule5 force-pushed the features/struct-enum-attributes branch from 0991b73 to b0e17f1 Compare June 12, 2024 23:57
@NightEule5
Copy link
Contributor Author

I noticed EnumValue is exposed but not exported

Copy link
Contributor

@VictorKoenders VictorKoenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@VictorKoenders VictorKoenders merged commit 8964502 into bincode-org:trunk Jun 14, 2024
7 checks passed
@NightEule5 NightEule5 deleted the features/struct-enum-attributes branch June 14, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing feature to specify attributes on GenStruct
2 participants