Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documenatation to clarify cacheFile #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdmunro
Copy link

@jdmunro jdmunro commented Feb 7, 2019

I noticed that .cacheFile doesn't respect the fileDirName that's been set in the options. This means that you might end up downloading the file twice, and can break certain offline solutions. This caught me out for a while so figured it was worth adding to the docs.

A future improvement would be to unify the two so that fileDirName is respected in both cases.

See this line, where no options are passed: https://github.com/billmalarky/react-native-image-cache-hoc/blob/master/lib/imageCacheHoc.js#L60

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.548% when pulling f3492bf on jdmunro:master into 20c438a on billmalarky:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants