Update documenatation to clarify cacheFile #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
.cacheFile
doesn't respect thefileDirName
that's been set in the options. This means that you might end up downloading the file twice, and can break certain offline solutions. This caught me out for a while so figured it was worth adding to the docs.A future improvement would be to unify the two so that
fileDirName
is respected in both cases.See this line, where no options are passed: https://github.com/billmalarky/react-native-image-cache-hoc/blob/master/lib/imageCacheHoc.js#L60