backend: Pass handle token to method calls for easier identification and association with their backend logic #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-mani-j
force-pushed
the
identify-request
branch
from
e5431e7 to
446c033
Compare
arun-mani-j
changed the title
|
v1:
|
|
HandleToken also needs to derive various traits like Hash, PartialEq,Eq and so on |
Will be used in subsequent commits for situations where we need to identify a `Request` but passing `ObjectPath` directly will be too much of exposure. Since handle tokens are supposed to be as unique as possible as per the specifications, we shall use them for these situations.
arun-mani-j
force-pushed
the
identify-request
branch
from
446c033 to
dfd0153
Compare
|
v2:
|
By having a handle token, an implementer can now associate further calls on the `Request` with its backend logic. For example, suppose an app A calls `Account.GetUserInformation()` followed by an app B. The implementer shows a dialog for each of them that lets the user give their response. Now, if any of these apps call `Request.close()`, then the implementer does not know which dialog to close, as it did not have any way to associate the `Request` to its backend logic in the first place. This commit solves this issue.
This lets the implementer to know on which `Request` `close` was called.
arun-mani-j
force-pushed
the
identify-request
branch
from
dfd0153 to
72223f8
Compare
|
v3:
|
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state of
ashpd::backend, it is difficult to associate each request with the backend logic. So any further calls on the request is left in ambiguity.For example, let's say two apps call
Account.GetUserInformation. Our implementation shows dialogs that lets the user enter their details. Now, if one of these apps cancel their request withRequest.close(), then it is impossible (or difficult) for implementer to know which dialog must be closed.An easy fix to this problem is to pass the object path of request on the method calls. Now the backend can associate each request with its backend logic, like say a hash map of requests to dialogs. Then, when
closemethod is called, it can identify which dialog to close and can close it.I'm a Rust newbie, so not sure if
clone()ing paths are a good idea or if we can tackle this problem from a different angle. 😅Thank you