Bugfix #186
Open
Bugfix #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Thank you! I will merge this in as soon as I have a chance to take a closer look. Thanks again! |
|
When I run the test.html page, there is a strange shift to the right with the header and footer when they become fixed. This is similar to the shift I see in pull request #140. I will need to correct this before I can merge this in. Thank you very much for your contribution! |
|
@ghost These changes fixed my scrolling problem! @bigspotteddog I am not sure what problems you ran into during your merge but this fixed the rapidly scrolling issue on my test page, I will report back if I run into any problems once I go live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a few bugs that are found during the use of plugin. Perhaps, it will be useful for you.
Particularly interesting, why use "target.bind('scroll...)"? Is it necessary? On my test page I have a "scrolltofixed" column with scrollable content inside and this code breaks the column's behaviour.