Merge pull request ClickHouse#65305 from ClickHouse/byepc

Disable userspace page cache by default

src/Common/ICachePolicy.h

@@ -48,7 +48,7 @@ class ICachePolicy
 
     /// HashFunction usually hashes the entire key and the found key will be equal the provided key. In such cases, use get(). It is also
     /// possible to store other, non-hashed data in the key. In that case, the found key is potentially different from the provided key.
-    /// Then use getWithKey() to also return the found key including it's non-hashed data.
+    /// Then use getWithKey() to also return the found key including its non-hashed data.
     virtual MappedPtr get(const Key & key) = 0;
     virtual std::optional<KeyMapped> getWithKey(const Key &) = 0;
 

src/Core/ServerSettings.h

@@ -86,7 +86,7 @@ namespace DB
     M(Double, index_mark_cache_size_ratio, DEFAULT_INDEX_MARK_CACHE_SIZE_RATIO, "The size of the protected queue in the secondary index mark cache relative to the cache's total size.", 0) \
     M(UInt64, page_cache_chunk_size, 2 << 20, "Bytes per chunk in userspace page cache. Rounded up to a multiple of page size (typically 4 KiB) or huge page size (typically 2 MiB, only if page_cache_use_thp is enabled).", 0) \
     M(UInt64, page_cache_mmap_size, 1 << 30, "Bytes per memory mapping in userspace page cache. Not important.", 0) \
-    M(UInt64, page_cache_size, 10ul << 30, "Amount of virtual memory to map for userspace page cache. If page_cache_use_madv_free is enabled, it's recommended to set this higher than the machine's RAM size. Use 0 to disable userspace page cache.", 0) \
+    M(UInt64, page_cache_size, 0, "Amount of virtual memory to map for userspace page cache. If page_cache_use_madv_free is enabled, it's recommended to set this higher than the machine's RAM size. Use 0 to disable userspace page cache.", 0) \
     M(Bool, page_cache_use_madv_free, DBMS_DEFAULT_PAGE_CACHE_USE_MADV_FREE, "If true, the userspace page cache will allow the OS to automatically reclaim memory from the cache on memory pressure (using MADV_FREE).", 0) \
     M(Bool, page_cache_use_transparent_huge_pages, true, "Userspace will attempt to use transparent huge pages on Linux. This is best-effort.", 0) \
     M(UInt64, mmap_cache_size, DEFAULT_MMAP_CACHE_MAX_SIZE, "A cache for mmapped files.", 0) \

tests/integration/test_disk_over_web_server/configs/storage_conf_web.xml

@@ -30,5 +30,7 @@
         </policies>
     </storage_configuration>
 
+    <page_cache_size>10000000000</page_cache_size>
+
     <query_log></query_log>
 </clickhouse>