Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move command structure to bdg-utils? #603

Closed
fnothaft opened this issue Mar 1, 2015 · 6 comments
Closed

Move command structure to bdg-utils? #603

fnothaft opened this issue Mar 1, 2015 · 6 comments
Milestone

Comments

@fnothaft
Copy link
Member

fnothaft commented Mar 1, 2015

The command infrastructure is useful for much more than ADAM, and isn't really specific to genomics. For example, I myself use it in avocado, PacMin, and a few non-genomics projects. I'd like to move it to bdg-utils. At the same point in time, I think we could roll the build information work (see here and here) to the main command (e.g., as a command line argument, -v/--version).

This is similar to how we pulled SparkFunSuite out of ADAM. It's really useful code, but for projects where I don't need to bring ADAM in as a dependency (e.g., the non-omics ones referred to earlier), I'd really prefer not to pull it in.

@fnothaft fnothaft added this to the 0.17.0 milestone Mar 1, 2015
@tdanford
Copy link
Contributor

tdanford commented Mar 1, 2015

As an alternative, move the command structure further up (or down, depending on your orientation) the food chain. I ended up replicating a subset of ADAMMain as a class called QCMain in the qc-metrics repository.

Maybe all the support classes (e.g. ADAMCommandCompanion) can go in bdg-utils, and all the actual Main classes and commands can go in downstream repos?

@fnothaft
Copy link
Member Author

fnothaft commented Mar 1, 2015

@tdanford

Maybe all the support classes (e.g. ADAMCommandCompanion) can go in bdg-utils, and all the actual Main classes and commands can go in downstream repos?

That'd be my preference as well.

@tdanford
Copy link
Contributor

tdanford commented Mar 1, 2015

+1.

@fnothaft
Copy link
Member Author

fnothaft commented Mar 5, 2015

@tdanford I've opened a PR upstream: bigdatagenomics/utils#30. I'll open a PR against ADAM tomorrow showing what these changes would look like.

@laserson
Copy link
Contributor

laserson commented Mar 5, 2015

+1 to factoring out the common stuff

@fnothaft
Copy link
Member Author

This was closed by #678.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants