Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTI-411: use exists? instead of where for performance #371

Merged
merged 1 commit into from
Dec 6, 2024
Merged

LTI-411: use exists? instead of where for performance #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/room.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def generate_unique_code
def shared_code_presence
errors.add(:shared_code, "The shared code can't be blank when 'Use Shared Code' is enabled") && return if shared_code.blank?

return if Room.where(code: shared_code, tenant: tenant).exists?
return if Room.exists?(code: shared_code, tenant: tenant)

errors.add(:shared_code, 'A room with this code could not be found')
end