LTI-413: don't do unnecessary db updates

bigbluebutton · Dec 9, 2024 · 7e2d8ec · 7e2d8ec
1 parent dbd5527
commit 7e2d8ec
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/app/jobs/room_meeting_watcher_job.rb b/app/jobs/room_meeting_watcher_job.rb
@@ -11,7 +11,7 @@ def perform(room, data)
 
     info = fetch_meeting_info(data)
     if info[:meeting_in_progress]
-      @chosen_room.update(watcher_job_active: true)
+      @chosen_room.update(watcher_job_active: true) unless @chosen_room.watcher_job_active # no need to update if it's already true
 
       logger.info("Meeting in progress. Sending broadcast to room '#{room.name}'")
       # Broadcast updates to this room’s channel
@@ -24,7 +24,7 @@ def perform(room, data)
 
       # Broadcast that the meeting ended
       MeetingInfoChannel.broadcast_to(room, { meeting_in_progress: false, action: 'end' })
-      @chosen_room.update(watcher_job_active: false)
+      @chosen_room.update(watcher_job_active: false) if @chosen_room.watcher_job_active # no need to update if it's already false
       # Do not re-enqueue, job ends here
     end
   end
@@ -42,8 +42,4 @@ def fetch_meeting_info(data)
     data[:participant_count] = info[:participantCount]
     data
   end
-
-  def meeting_running?(info)
-    info[:returncode] == 'SUCCESS' && info[:running] == true
-  end
 end