Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14] - Change layout and add translatable strings #22

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jordanharris-6
Copy link

@jordanharris-6 jordanharris-6 commented Nov 1, 2024

Description

14 - This PR changes the layout how the release notes are displayed within the admin

Change Log

  • Adds a util function to get the formatted date based on the site options
  • Refactors the widget and item renders so to match the requested layout

Steps to test

Add a new release note using the menu on the left
add some content to the release note, a version number and a date its going live in the right menu.
Publish the release
Click the version top right of the screen
check the format matches what it says in the ticket

Open a new tab and go to settings > general
find the date option and change it
go back to the release note you have created and refresh the format of the date should have changed now.

Screenshots/Videos

http://bigbite.im/v/20Vcvr

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@jordanharris-6 jordanharris-6 marked this pull request as ready for review November 15, 2024 16:28
@johnmunster
Copy link
Contributor

Adding these here, as Jordan asked me to look at this PR, and this was some of my feedback earlier in the development process.
http://bigbite.im/i/IAj3ar
It looks better than it did. Couple of suggestions:
Remove the square brackets (I think I only put them in as placeholders)
Change the date format on the release date to dd/mm/yyyy
Put the version in brackets, so it reads release title (version x.x.x)

@johnmunster
Copy link
Contributor

Have since seen the final implementation and I am happy with the new look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants