Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[28][29][31] Width and Height block settings #39

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[28][29][31] Width and Height block settings #39

wants to merge 12 commits into from
+54 −25

Commits on Oct 7, 2024

  1. fix: assign height and width a default value of null 

    Fixes an issue where editing settings.layout.contentSize in theme.json would not change the width of the block.
    @PaulREnglish
    PaulREnglish committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3daf7b4 View commit details
    Browse the repository at this point in the history

  2. fix(image-comparison): move block props into own function 

    This was needed to fix 'Arrow function has a complexity of 12. Maximum allowed is 10' JS lint error
    @PaulREnglish
    PaulREnglish committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8c657d8 View commit details
    Browse the repository at this point in the history

  3. Revert "fix(image-comparison): move block props into own function" 

    This reverts commit 8c657d8.
    @PaulREnglish
    PaulREnglish committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d7a2b22 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. fix(image comparison): create function for getting container size 

    This was needed to fix 'Arrow function has a complexity of 12. Maximum allowed is 10' JS lint error
    @PaulREnglish
    PaulREnglish committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    97c4c27 View commit details
    Browse the repository at this point in the history

  2. docs: fix invalid getContainerSize typehinting in docblock

    @PaulREnglish
    PaulREnglish committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    6edfadc View commit details
    Browse the repository at this point in the history

  3. fix(image-comparison): allows alignment settings to affect the block

    @PaulREnglish
    PaulREnglish committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1b5d327 View commit details
    Browse the repository at this point in the history

  4. docs: correct return param type in getContainerSize docblock

    @PaulREnglish
    PaulREnglish committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e304e01 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix/width-height-default-null' into fix/no-layout-align… 

    …ment-override
    @PaulREnglish
    PaulREnglish committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    360a294 View commit details
    Browse the repository at this point in the history

  6. fix: fix alignment functionality on front end

    @PaulREnglish
    PaulREnglish committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    812ffc0 View commit details
    Browse the repository at this point in the history

  7. fix: hide width/height settings when alignment is set

    @PaulREnglish
    PaulREnglish committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    30fe54b View commit details
    Browse the repository at this point in the history

  8. docs: improve getContainerSize docblock description

    @PaulREnglish
    PaulREnglish committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    71f341a View commit details
    Browse the repository at this point in the history

  9. Merge branch 'fix/width-height-default-null' into fix/no-layout-align… 

    …ment-override
    @PaulREnglish
    PaulREnglish committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a95da67 View commit details
    Browse the repository at this point in the history