-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
some code cleanup regarding keyfiles with prefix (PR #9)
- Loading branch information
Showing
2 changed files
with
55 additions
and
80 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55c3ae5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the generate_keys script I used
while i<=args.keys:
instead of
for i in range(args.nkeys):
because if this condition is triggered (and it is from time to time)
if '/' in s256_b64[:7]:
you end up generating less keys than requested
55c3ae5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you'r right, I just hit that after committing this.. I'll put that back later, I don't use this almost ever. It will probably come along with biemster/st17h66_FindMy#2
55c3ae5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see that the missing/found keys are not sorted. This was just to test if the tag is correctly cycling through all the keys, and it's easier to spot an error if they are sorted.
Oh, and printing the length also helped.
This is a debug option so it's probably best to only show it with a command line switch.