-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to allow Deno check to pass and build to succeed. #2161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnore the issues.add because thats poorly typed. Update Deno.run to Deno.Command. Removes stubfile validators/isBidsy.ts.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2161 +/- ##
=======================================
Coverage 85.73% 85.73%
=======================================
Files 91 91
Lines 3785 3785
Branches 1220 1220
=======================================
Hits 3245 3245
Misses 454 454
Partials 86 86 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Oct 15, 2024
effigies
reviewed
Oct 21, 2024
rwblair
force-pushed
the
fix/deno_2_test_and_build
branch
from
October 24, 2024 20:11
0c55d23
to
6923b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add further type checks to catching errors that are thrown issues (then immediately ts-ignore the issues.add).
I think to remove the @ts-expect-error on the issue.adds we'd need to have issues be a class, instantiate instances in the throw statement then we could leverage instanceof in the catch statements.
I tried to put the type guard into a function to reduce how often all those && were being repeated but TS wasn't having any of it. Not sure what I was doing wrong. Similarly TS didn't like
hasOwn
so had to usein
operator.Update Deno.run to Deno.Command, run removed in deno2.
Removes stub file validators/isBidsy.ts.