Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to allow Deno check to pass and build to succeed. #2161

Closed
wants to merge 29 commits into from

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Oct 14, 2024

Add further type checks to catching errors that are thrown issues (then immediately ts-ignore the issues.add).
I think to remove the @ts-expect-error on the issue.adds we'd need to have issues be a class, instantiate instances in the throw statement then we could leverage instanceof in the catch statements.

I tried to put the type guard into a function to reduce how often all those && were being repeated but TS wasn't having any of it. Not sure what I was doing wrong. Similarly TS didn't like hasOwn so had to use in operator.

Update Deno.run to Deno.Command, run removed in deno2.

Removes stub file validators/isBidsy.ts.

…gnore the issues.add because thats poorly typed. Update Deno.run to Deno.Command. Removes stubfile validators/isBidsy.ts.
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (80b2789) to head (d941cf6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2161   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files          91       91           
  Lines        3785     3785           
  Branches     1220     1220           
=======================================
  Hits         3245     3245           
  Misses        454      454           
  Partials       86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

effigies and others added 21 commits October 14, 2024 20:40
@rwblair rwblair force-pushed the fix/deno_2_test_and_build branch from 0c55d23 to 6923b6f Compare October 24, 2024 20:11
@rwblair rwblair closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants