Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vite web validator for the schema validator #1915

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

nellh
Copy link
Member

@nellh nellh commented Mar 12, 2024

Adds a vite project to run the schema validator. Decided to put this at the top level under web, it really doesn't depend on anything except a build path for the schema validator.

The browser bundle target is not watched for changes but run once when you start dev or build modes.

# Live reload for development
cd web && deno task dev
# Build for static deployments
cd web && deno task build

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (39baeb8) to head (4834715).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
+ Coverage   83.57%   85.46%   +1.89%     
==========================================
  Files          92      131      +39     
  Lines        3890     6262    +2372     
  Branches     1271     1544     +273     
==========================================
+ Hits         3251     5352    +2101     
- Misses        541      806     +265     
- Partials       98      104       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator

Looks great!

image

Missing lists of affected files, though.

@nellh
Copy link
Member Author

nellh commented Mar 21, 2024

Missing lists of affected files, though.

If the issue generated includes them they are displayed as a list of paths but this seems to be missing from a number of the issues generated.

@rwblair rwblair merged commit 39ff142 into bids-standard:master Mar 21, 2024
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants