Use generic TSV file class from hed-validator package #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously used classes, BidsEventFile and BidsTabularFile, have been deprecated. The parameter order is slightly different between the respective constructors, so that has been tweaked. Fixes bids-standard#1868
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1898 +/- ##
==========================================
- Coverage 83.53% 83.52% -0.02%
==========================================
Files 92 92
Lines 3894 3890 -4
Branches 1273 1271 -2
==========================================
- Hits 3253 3249 -4
Misses 543 543
Partials 98 98 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously used classes,
BidsEventFileandBidsTabularFile, have been deprecated. The parameter order is slightly different between the respective constructors, so that has been tweaked.Fixes #1868