Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hed-validator version 3.13.0 #1868

Closed
sappelhoff opened this issue Dec 18, 2023 · 5 comments · Fixed by #1898
Closed

hed-validator version 3.13.0 #1868

sappelhoff opened this issue Dec 18, 2023 · 5 comments · Fixed by #1898

Comments

@sappelhoff
Copy link
Member

          hed-validator version 3.13.0 has been released on npm.  This release supports the new curly brace notation, improves tests, and fixes a few bugs.  Please update the npm dependencies for it.  Thx.   @sappelhoff

Originally posted by @VisLab in https://github.com/bids-standard/bids-validator/issues/1866#issuecomment-1860740596

@sappelhoff
Copy link
Member Author

@happy5214
Copy link
Collaborator

happy5214 commented Jan 5, 2024

Co-opting this issue to say that hed-validator needs to be bumped to 3.13.2 now to fix the issue in https://github.com/bids-standard/bids-validator/pull/1869#issuecomment-1865993337. Also, all instances of BidsEventFile and BidsTabularFile (which are now deprecated) should be replaced with BidsTsvFile. This version provides full support for HED validation in all BIDS TSV files with column headers (i.e. those that aren't timeseries) and associated sidecars. I ran into issues bumping the package-lock.json myself without changing your hard-coded version dependencies.

@happy5214
Copy link
Collaborator

@rwblair This now needs to be bumped to 3.13.3 to fix a minor issue with generating plural forms for non-SI, non-symbol units.

@sappelhoff
Copy link
Member Author

@happy5214 if you tell me the commands I need to run to do this, OR if you make a PR yourself, we can get this done between the two of us.

@happy5214
Copy link
Collaborator

happy5214 commented Feb 23, 2024

This was fixed by #1879. Please close.

Edit. Not true. The assignment to TsvFileClass starting at https://github.com/bids-standard/bids-validator/blob/f50efda00818e50256586caa712aec74a90301c4/bids-validator/validators/hed.js#L55 needs to be replaced with hedValidator.bids.BidsTsvFile (and inlined).

happy5214 added a commit to happy5214/bids-validator that referenced this issue Feb 24, 2024
The previously used classes, BidsEventFile and BidsTabularFile, have
been deprecated. The parameter order is slightly different between
the respective constructors, so that has been tweaked.

Fixes bids-standard#1868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants