Add another example to inheritance principle for .json without entities #2019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon re-reading current Inheritance principle formulation, nothing seems to
forbid that, and such use in general is great since allows to generalize
common metadata across all files of that datatype.
Notes on possible side-effects from "embracing" such approach (which in
principle I think is not disallowed ATM).
per rule 4, presence of
bold.json
forbids presence of another_bold.json
(i.e with entity) on the same level. So if further specialization e.g. per
each task- is needed, common metadata needs to be duplicated across them
(that is what heudiconv does ATM).
Such restrictions could potentially be elevated if we adopt
"summarization" refactoring of inheritance principle
Replace "inheritance" with "summarization" principle bids-2-devel#65
since order would stop to matter and thus multiple files can apply.
I think that bids-validators are fine as checked on a single
ds000248/T1w.json in bids-examples and modified 7t_trt.
I do not know if tools implement it though but since there was precedence
for ds000248/T1w.json - they better do ;-)