-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] graceful error when failing to load invalid yml #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Remi-Gau
commented
Dec 16, 2024
- closes ungracefull error when loading schema with yaml syntax error #2008
The error at least now mentions in which file the error is.
|
Remi-Gau
commented
Dec 16, 2024
@@ -116,6 +116,7 @@ plugins: | |||
- css/watermark.css | |||
- macros: | |||
module_name: tools/mkdocs_macros_bids/main | |||
on_error_fail: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding this extra check because the wesbite would still build but with broken pages which is not something we want
effigies
reviewed
Dec 16, 2024
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
approved these changes
Dec 17, 2024
effigies
added
schema-code
Updates or changes to the code used to parse, filter, and render the schema.
exclude-from-changelog
This item will not feature in the automatically generated changelog
labels
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exclude-from-changelog
This item will not feature in the automatically generated changelog
schema-code
Updates or changes to the code used to parse, filter, and render the schema.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.