Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[ENH] Specify the naming of scanner-generated TRACE and ADC volumes" #1919

Merged
merged 1 commit into from
Sep 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 7 additions & 19 deletions src/modality-specific-files/magnetic-resonance-imaging-data.md
Original file line number Diff line number Diff line change
Expand Up @@ -660,18 +660,13 @@ The definitions of these fields can be found in
and a guide for using macros can be found at
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
-->
{{ MACROS___make_suffix_table(["dwi", "sbref"]) }}

Additionally, the following suffixes are used for scanner-generated images:

<!--
This block generates a suffix table.
The definitions of these fields can be found in
src/schema/rules/files/raw
and a guide for using macros can be found at
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
-->
{{ MACROS___make_suffix_table(["ADC", "TRACE"]) }}
{{ MACROS___make_suffix_table(
[
"dwi",
"sbref",
]
)
}}

<!--
This block generates a filename templates.
Expand Down Expand Up @@ -700,13 +695,6 @@ In such a case, two files could have the following names:
The user is free to choose any other label than `singleband` and
`multiband`, as long as they are consistent across subjects and sessions.

Scanner-generated TRACE and ADC volumes MAY be included using the
`TRACE` and `ADC` suffixes.
If TRACE or ADC volume filenames match a diffusion series with all applicable entities,
such volumes SHOULD be computed from that series.
Otherwise, some entity, such as [`acq-<label>`](../appendices/entities.md#acq),
SHOULD be used to indicate that the files are unrelated.

### REQUIRED gradient orientation information

The REQUIRED gradient orientation information corresponding to a DWI acquisition
Expand Down
10 changes: 0 additions & 10 deletions src/schema/objects/suffixes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ TwoPE:
display_name: 2-photon excitation microscopy
description: |
2-photon excitation microscopy imaging data
ADC:
value: ADC
display_name: Apparent diffusion coefficient (ADC)
description:
Apparent diffusion coefficient (ADC) map
BF:
value: BF
display_name: Bright-field microscopy
Expand Down Expand Up @@ -465,11 +460,6 @@ TEM:
display_name: Transmission electron microscopy
description: |
Transmission electron microscopy imaging data
TRACE:
value: TRACE
display_name: Trace diffusion weighted image
description: |
Diffusion images proportional to the trace of the diffusion tensor
UNIT1:
value: UNIT1
display_name: Homogeneous (flat) T1-weighted MP2RAGE image
Expand Down
9 changes: 0 additions & 9 deletions src/schema/rules/files/deriv/imaging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,6 @@ dwi_volumetric:
density: optional
description: optional

dwi_isotropic:
$ref: rules.files.raw.dwi.isotropic
entities:
$ref: rules.files.raw.dwi.isotropic.entities
space: optional
resolution: optional
density: optional
description: optional

func_volumetric:
$ref: rules.files.raw.func.func
entities:
Expand Down
20 changes: 0 additions & 20 deletions src/schema/rules/files/raw/dwi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,23 +38,3 @@ sbref:
run: optional
part: optional
chunk: optional

# Common scanner-generated derivatives need raw names
isotropic:
suffixes:
- ADC
- TRACE
extensions:
- .nii.gz
- .nii
- .json
datatypes:
- dwi
entities:
subject: required
session: optional
acquisition: optional
reconstruction: optional
direction: optional
run: optional
chunk: optional