-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative proposal to BEP038 #1856
base: bep038
Are you sure you want to change the base?
Changes from 17 commits
4fa15e5
0180e3b
bba4159
f159e61
9390602
3f8c210
927335c
6a3dcc7
f7e906d
57160cd
1db3fd4
48e77ae
d6cf6a4
8bfc7ac
f2be20a
d15677a
b275ca3
f9ff346
f0e8e0e
b00bdf8
abe37b4
d812b08
3accb28
e5e27f1
8ffda51
d62f0d9
161db11
44cb808
c77df10
947f279
a5111aa
c05146c
f221ad0
9ec94cd
1a258b5
79f1ea9
3f2bde5
95a85a1
0d7f965
a9fa24a
44c3ad8
b66c3ee
c3b6f41
891bcf0
ef1817b
bc6b064
226f134
ac745e6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -29,14 +29,7 @@ atlas: | |||||||
name: atlas | ||||||||
display_name: Atlas | ||||||||
description: | | ||||||||
The definition of atlas per Merriam-Webster is ‘a bound collection of maps (i.e. labeled brain regions | ||||||||
or quantitative aspects) and metadata (tables, or textual matter). Within BIDS, atlases are broadly | ||||||||
defined as a mapping between locations in a spatial coordinate systems and descriptions associated with | ||||||||
those locations. Atlases are often build from registering many subjects or maps to a template. By analogy | ||||||||
with geographical atlases, brain atlases can map brain locations to either discrete labels like a map | ||||||||
of countries does, or to continuous quantities like a topographic map does. | ||||||||
|
||||||||
This comprises all possible types of atlases, specifically deterministic, probabilistic, and mask/voxel-based | ||||||||
Atlas comprises all possible types of atlases, specifically deterministic, probabilistic, and mask/voxel-based | ||||||||
ones, and quantitative maps from various modalities including but not limited to structural features (e.g. | ||||||||
myelination, cytoarchitecture), functional features (e.g. resting-state networks, localizers) and such based on | ||||||||
multimodal data integration (e.g. gene expression, receptors). Furthermore, it covers both volume/voxel and | ||||||||
|
@@ -53,6 +46,14 @@ ceagent: | |||||||
`"ContrastBolusIngredient"` MAY also be added in the JSON file, with the same label. | ||||||||
type: string | ||||||||
format: label | ||||||||
cohort: | ||||||||
name: cohort | ||||||||
display_name: Cohort | ||||||||
description: | | ||||||||
A subset of a defined template space, for instance, for a longitudinal template of brain development | ||||||||
where infants were participants were averaged at three, six, and twelve months old. | ||||||||
Comment on lines
+55
to
+56
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've removed the example, because that didn't seem like a cohort to me. In my mental model is a longitudinal study is one or more cohorts with observations at multiple timepoints. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, then, maybe we need to find an alternate entity name because the term 'cohort' comes from TemplateFlow, and there, we do use it to separate different ages within a single template/atlas. It's also the intention here: to have a single standard space name that, in reality, has several standard spaces within. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As per merriam webster it doesn't seem like a bad choice: https://www.merriam-webster.com/dictionary/cohort There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh sorry, I misunderstood. I agree with the merriam webster definition and now understand the longitudinal example. I had originally though the example was referring to multiple timepoints at 3, 6 and 12 months old. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe the definition could be more clear, please send suggestions if you think we can make it better :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My suggested change is above. I suggest changing the definition to "A sub-population over which an atlas or template is derived." and removing the example. |
||||||||
type: string | ||||||||
format: label | ||||||||
chunk: | ||||||||
name: chunk | ||||||||
display_name: Chunk | ||||||||
|
@@ -300,7 +301,33 @@ segmentation: | |||||||
display_name: Segmentation | ||||||||
description: | | ||||||||
The `seg-<label>` key/value pair corresponds to a custom label the user | ||||||||
MAY use to distinguish different segmentations. | ||||||||
MAY use to distinguish different segmentations or parcellations. | ||||||||
|
||||||||
For atlases, `seg-<label>` distinguish different realizations of a given | ||||||||
segmentation or parcellation. | ||||||||
For example, the [Yeo 2011 atlas](https://doi.org/10.1152/jn.00338.2011) | ||||||||
is distributed within *FreeSurfer* with two different parcellations | ||||||||
(*7 networks* and *17 networks*). | ||||||||
|
||||||||
This entity is only applicable to derivative data. | ||||||||
type: string | ||||||||
format: label | ||||||||
scale: | ||||||||
name: scale | ||||||||
display_name: Scale | ||||||||
description: | | ||||||||
The `scale-<label>` key/value pair corresponds to a custom label the user | ||||||||
MAY use to distinguish segmentations that entail different levels of | ||||||||
*regional resolution* (scales), often indicated by the number of ROIs. | ||||||||
See ([Bijsterbosch et al., 2020](https://doi.org/10.1038/s41593-020-00726-z)) | ||||||||
for further details on *regional resolution* or, as defined by the authors of | ||||||||
the manuscript, the *brain units*. | ||||||||
|
||||||||
For example, the [Schaefer 2018 atlas](https://doi.org/10.1093/cercor/bhx179) | ||||||||
is distributed within *FreeSurfer* with ten different scales | ||||||||
(100, 200, 300, 400, 500, 600, 700, 800, 900, and 1000 regions) for each of | ||||||||
its three different parcellations (*7 networks*, *17 networks*, and | ||||||||
*Kong's variation of 17 networks*). | ||||||||
|
||||||||
This entity is only applicable to derivative data. | ||||||||
type: string | ||||||||
|
@@ -412,6 +439,16 @@ task: | |||||||
the `task` label for resting state files (for example, `task-rest`). | ||||||||
type: string | ||||||||
format: label | ||||||||
template: | ||||||||
name: tpl | ||||||||
display_name: Template | ||||||||
description: | | ||||||||
An standardized space of analysis specified or engendered by one or more average of features | ||||||||
with respect to which group-level and atlas-derived results are provided. | ||||||||
The `<label>` MAY be taken from one of the modality specific lists in the | ||||||||
[Coordinate Systems Appendix](SPEC_ROOT/appendices/coordinate-systems.md). | ||||||||
type: string | ||||||||
format: label | ||||||||
tracer: | ||||||||
name: trc | ||||||||
display_name: Tracer | ||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,9 @@ | |
- task | ||
- event | ||
- run | ||
- template | ||
- atlas | ||
- space | ||
- index | ||
- label | ||
- suffix | ||
|
oesteban marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pwighton can you make a code suggestion here to replace/edit/improve the definition of cohorts? Thanks!