Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Refactor metaschema file rules into definitions #1808

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

effigies
Copy link
Collaborator

This should be reviewed as two separate commits. The first contains the change I want to make, the second just runs prettier to enforce a consistent style.

@effigies effigies added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Apr 26, 2024
@effigies effigies requested a review from bendichter April 26, 2024 15:23
src/metaschema.json Outdated Show resolved Hide resolved
@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (3322a40) to head (0c6e8ce).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1808   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files          16       16           
  Lines        1375     1375           
=======================================
  Hits         1209     1209           
  Misses        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the metaschema-file-rules branch from acac248 to 0c6e8ce Compare April 26, 2024 15:37
Copy link
Contributor

@bendichter bendichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@effigies effigies merged commit f0bc977 into bids-standard:master Apr 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants