-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add descriptions.tsv
to the schema
#1707
Conversation
Switching to a draft until I figure out how to render the filename template. |
I've given up on rendering the template with a macro, but I'll bring up adding checks for the file in the schema meeting today. Presumably we would want rules to check if all |
Co-authored-by: Chris Markiewicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1707 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 16 16
Lines 1351 1351
=======================================
Hits 1188 1188
Misses 163 163 ☔ View full report in Codecov by Sentry. |
descriptions is a suffix, rather than a file.
I will open an issue about my two pain points:
EDIT: I've opened #1710. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving for merge as soon as "good enough" and to then cover the pain points in a follow-up (or several).
@tsalo |
No reason- I didn't realize I had two approvals. I'll update from main and then merge once CI passes. |
Closes none, but continues from #1613.
I didn't figure out how to render the filenames in a macro. I think allowing
descriptions.tsv
files at the subject or session level introduced more complexity than it was worth, unfortunately.I also haven't figured out how to add meaningful rules about the file to the schema. Specifically, we probably want to raise a warning if any desc values described in the file aren't in the dataset, or vice versa.
Changes proposed:
descriptions.tsv
file to the schema.