Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add ElectricalStimulation and *Parameters metadata to MEEG jsons #1638

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Oct 24, 2023

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (405b053) 87.83% compared to head (c881c91) 87.83%.
Report is 2 commits behind head on master.

❗ Current head c881c91 differs from pull request most recent head 4ddf09f. Consider uploading reports for the commit 4ddf09f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1638   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1191     1191           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dorahermes dorahermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to add these fields to the spec in a new table, such as here for EEG:

Those fields MUST be present:
<!-- This block generates a metadata table.
These tables are defined in
src/schema/rules/sidecars
The definitions of the fields specified in these tables may be found in
src/schema/objects/metadata.yaml
A guide for using macros can be found at
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
-->
{{ MACROS___make_sidecar_table("eeg.EEGRequired") }}
Those fields SHOULD be present:
<!-- This block generates a metadata table.
These tables are defined in
src/schema/rules/sidecars
The definitions of the fields specified in these tables may be found in
src/schema/objects/metadata.yaml
A guide for using macros can be found at
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
-->
{{ MACROS___make_sidecar_table("eeg.EEGRecommended") }}

@sappelhoff sappelhoff changed the title ENH: add ElectricalStimulation and *Parameters to MEEG [ENH] add ElectricalStimulation and *Parameters metadata to MEEG jsons Oct 26, 2023
@sappelhoff sappelhoff requested a review from effigies October 26, 2023 08:46
@sappelhoff sappelhoff merged commit ce1e2bc into bids-standard:master Nov 2, 2023
17 checks passed
@sappelhoff sappelhoff deleted the elec_stim_meeg branch November 2, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

electrical stimulation during MEG/EEG recordings
4 participants