-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add ElectricalStimulation
and *Parameters
metadata to MEEG jsons
#1638
Conversation
f7fbbd3
to
c881c91
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1638 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 16 16
Lines 1356 1356
=======================================
Hits 1191 1191
Misses 165 165 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we need to add these fields to the spec in a new table, such as here for EEG:
bids-specification/src/modality-specific-files/electroencephalography.md
Lines 92 to 114 in efbe6ab
Those fields MUST be present: | |
<!-- This block generates a metadata table. | |
These tables are defined in | |
src/schema/rules/sidecars | |
The definitions of the fields specified in these tables may be found in | |
src/schema/objects/metadata.yaml | |
A guide for using macros can be found at | |
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md | |
--> | |
{{ MACROS___make_sidecar_table("eeg.EEGRequired") }} | |
Those fields SHOULD be present: | |
<!-- This block generates a metadata table. | |
These tables are defined in | |
src/schema/rules/sidecars | |
The definitions of the fields specified in these tables may be found in | |
src/schema/objects/metadata.yaml | |
A guide for using macros can be found at | |
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md | |
--> | |
{{ MACROS___make_sidecar_table("eeg.EEGRecommended") }} |
ElectricalStimulation
and *Parameters
metadata to MEEG jsons
related bids-validator legacy PR: