-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for .nwb standard/file format to be used for "micr" #1632
base: master
Are you sure you want to change the base?
Conversation
this may be more of a question of physiology versus microscopy. in bids micr is focused on anatomy-based info not physiology. and i don't think nwb quite fits into that space. ophys doesn't fit into micr as far as i can tell. in bids ophys would go into func. |
or |
re "functional vs anatomical"related discussions to tease apart those two notions of modality (MRI, micr, ...) and data type (anat vs func):
Note that nothing in https://bids-specificabtrcitetcjtion.readthedocs.io/en/stable/04-modality-specific-files/10-microscopy.html explicitly restricts to anatomy (in effect - allows for extra), although indeed lacks any annotation for temporal component and events (requires "extending"). So I could argue about similarity to this case here re phys vs micrATM microscopy is for the modality, and it already supports 2PE which I guess also falls into "phys" domain. |
has there been a request by a user / a particular group of users to make this happen? If not, I would wait with introducing such a change, and remain "use case driven". Especially when an argument of being "consistent" isn't entirely clear (as I get the impression, reading the discussion above) |
it was brought up as a side-topic in discussion of BEP032 (@BEP032) .
LGTM. @bendichter, are you aware of any DANDI set with nwb microscopy data which we would run to while approaching conversion of DANDI dandisets to BIDS? |
Yes, there are lots of ophys dandisets, including 1p, 2p, and more. Here are some good examples:
Among others... |
See https://pynwb.readthedocs.io/en/stable/tutorials/domain/ophys.html for support of various microscopy modalities within NWB. As NWB is already supported for other modalities, there is some support for microscopy in NWB in various tools, and as there are datasets with .nwb -- it makes sense to allow for .nwb to be used for microscopy data as well where appropriate.
3927bca
to
97bd21c
Compare
There is an ongoing effort of https://github.com/con/nwb2bids . Not yet sure how we would deal with multimodal nwb files like in https://dandiarchive.org/dandiset/000037/0.240209.1623/files?location=sub-408021&page=1 but I remain of opinion that NWB is a viable and used format for |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1632 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 16 16
Lines 1351 1351
=======================================
Hits 1188 1188
Misses 163 163 ☔ View full report in Codecov by Sentry. |
What benefits does That said, I know nothing of this space, and IMO this needs input from microscopy contributors. @jcohenadad do you have thoughts here? |
See https://pynwb.readthedocs.io/en/stable/tutorials/domain/ophys.html for support of various microscopy modalities within NWB. As NWB is already supported for other modalities, there is some support for microscopy in NWB in various tools, and as there are datasets with .nwb -- it makes sense to allow for .nwb to be used for microscopy data as well where appropriate.