[FIX] Update links that threw warning in CI #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Remi-Gau
commented
Sep 26, 2023
•
Remi-Gau
commented
- closes Failing check links in CI #1619
Remi-Gau
added
the
exclude-from-changelog
for more information, see https://pre-commit.ci
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1620 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 16 16
Lines 1356 1356
=======================================
Hits 1191 1191
Misses 165 165 ☔ View full report in Codecov by Sentry. |
Remi-Gau
requested review from
tsalo,
erdalkaraca,
ezemikulan and
sappelhoff
as code owners
Remi-Gau
commented
Sep 26, 2023
| @@ -9,7 +9,7 @@ MRI acquisition parameters are divided into several categories based on | |||
| ([article](https://doi.org/10.15200/winn.143191.17127)) by Ben Inglis. | |||
|
|
|||
| When adding additional metadata please use the CamelCase version of | |||
| [DICOM ontology terms](https://scicrunch.org/scicrunch/interlex/dashboard) | |||
| [DICOM ontology terms](https://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_d.html) | |||
There was a problem hiding this comment.
that's pretty much the only one where I am not so sure this is the best link for this
There was a problem hiding this comment.
I wonder if https://bioportal.bioontology.org/ontologies/DCM might not be better. @dbkeator Any thoughts?
sappelhoff
approved these changes
Sep 27, 2023
effigies
approved these changes
Sep 28, 2023
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.