-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] BEP 020 Eye Tracking #1128
Open
mszinte
wants to merge
193
commits into
bids-standard:master
Choose a base branch
from
mszinte:bep020
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,166
−65
Open
Changes from 1 commit
Commits
Show all changes
193 commits
Select commit
Hold shift + click to select a range
a73a9ea
create branch bep020
chloepasturel b43e979
Add datatype metadata and suffixes for eye tracking
chloepasturel ac14d18
bep020 md
greckla 3316ef5
Update 10-eye-tracking.md
greckla 033a948
minor update md
greckla 971ac2a
minor updates md 2
greckla 6236f83
final changes and working version with mkdocs
1d71719
add forgotten example
131b75d
final changes
b7f4d5d
latest changes
5aa62f7
Update 10-eye-tracking.md
mszinte 686a5f3
Apply suggestions from code review
Remi-Gau 4a46c9f
Merge branch 'master' into bep020
Remi-Gau 0388cc1
fix bad latin
Remi-Gau e4f72c9
md lint
Remi-Gau 19d4b6c
fix yml
Remi-Gau 7b6721d
md lint
Remi-Gau 6a71758
lint yml
Remi-Gau 7941bab
add semantic line breaks
Remi-Gau f1c255b
move suffix
Remi-Gau 2ffe348
rm CogPOID and CogAtlas yml
Remi-Gau e7658c9
move some metadata
Remi-Gau 3d2bf96
move more metadata
Remi-Gau 0369d4e
move more metadata
Remi-Gau 53e80f1
rely on task.yml for events
Remi-Gau 9f87572
change extension to tsv
Remi-Gau d19eaf8
fix schema
Remi-Gau d222325
fix links
Remi-Gau 7c3a071
fix typos
Remi-Gau 53d7894
fix link
Remi-Gau 0cd1366
most of the change but mkserve not working yet
108c18c
some more change still not working
df50fd8
change in mkdocs.yml based on commments
c90de08
run pre-commit and fix yml
Remi-Gau e01eed1
Merge branch 'master' into bep020
Remi-Gau 5cc22ba
add eyetrack modality object
Remi-Gau 647af5e
format markdown
Remi-Gau 77bf482
format markdown
Remi-Gau 141e480
space missing in tabular_data/eyetrack.yaml
8c7618f
merging
d678149
fixing conflict for real
01332e5
automatic changes by pre-commit
b89469e
instru
8fc5f0f
pre-commit stuff
6fce90b
correct error of manipulation of logo.eps
0009d63
some test
dc793a3
some test
a5f7cfc
some test
2f81069
some test
63352df
changes of columns names
564a206
Update src/modality-specific-files/eye-tracking.md
mszinte d6e8aed
change in metadata
42f4527
Merge branch 'bep020' of https://github.com/mszinte/bids-specificatio…
7ca6a42
test new changes with pre-commit
7d435de
correct error in eyetrack.md
ea1d18f
add RecordTimeStart and RecordTimeEnd
49ec9e9
cahnge eye_sample to eye_timestamp
7fb149c
correct error example json
7a55abd
error in datasets links
e3f74f8
last round of review on main doc
9df5c68
slight modif of SAOI
c45f480
slight modif of main md
edc7c6f
correction of space
518d8f6
try without modality
8549d0e
Update src/modality-specific-files/eye-tracking.md
mszinte f194526
put back mkdocs.yaml with unsorted modality specific files
0e0f800
Update src/modality-specific-files/eye-tracking.md
mszinte 15f817e
Update src/schema/objects/metadata.yaml
mszinte 171eff9
Update src/schema/objects/metadata.yaml
mszinte d0c919a
Update src/schema/objects/metadata.yaml
mszinte 39deaae
change after review of tsalo
b621542
Merge branch 'bep020' of https://github.com/mszinte/bids-specificatio…
c76af5b
put back /tool/filetree_exampl.ipynb
70c5edb
instru
9f223a1
change on metadata based on tsalo comments
a9bfaaf
change to desambiguate the columns in case of two eyes recording
4c8327b
change to account for the BEP020
c6a8354
change of json example in reply to https://github.com/bids-standard/b…
81d960e
change RecordTimeStart and RecordTimeEnd to StartTime_eyetrack (with …
1796cec
take out Scree settings from metadata as they were put in the main br…
457e339
Merge branch 'master' into bep020
mszinte a0410f8
insist on calibration in the text
e4c8ad8
add eyetrack suffix to timeseries suffixes in task.yaml in order to a…
f063523
point 2 on suggestion https://github.com/bids-standard/bids-specifica…
720311c
Merge remote-tracking branch 'upstream/master' into bep020
Remi-Gau 7868f57
fix markdown
Remi-Gau 8269cd3
fix markdown
Remi-Gau c4c342b
Merge branch 'master' into bep020
Remi-Gau 752e38d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 893911c
Merge branch 'master' into bep020
Remi-Gau d802ab2
Merge branch 'master' into bep020
Remi-Gau af48333
Merge remote-tracking branch 'upstream/master' into bep20
Remi-Gau 37f7cd1
codespell fixes
Remi-Gau 9ecb9ea
schema fix
Remi-Gau e286064
change to follow recommandations of https://doi.org/10.3758/s13428-02…
e513efa
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a414937
Merge branch 'master' into bep020
Remi-Gau 6f535cb
split metadata
Remi-Gau 3ac5ca5
fix metadata
Remi-Gau a31fbdd
format
Remi-Gau 17f296d
fix typo
Remi-Gau 691ec27
update example
Remi-Gau a4af030
make gunzip optional
Remi-Gau c9787a8
Merge branch 'master' into bep020
Remi-Gau a0acebe
add required events.json metadata
Remi-Gau f96f383
fix list
Remi-Gau 08250d3
fix list
Remi-Gau 95d6dbf
Merge branch 'master' into bep020
Remi-Gau 2169021
Update eye-tracking.md
mszinte 9314fc0
Changes for metadata
julia-pfarr 8e01771
Merge pull request #1 from julia-pfarr/julia
julia-pfarr 1aeeff5
Merge pull request #5 from julia-pfarr/bep020
julia-pfarr 2b85072
change unit of ScreenSize in example events.json
julia-pfarr 754f1c0
Merge pull request #6 from julia-pfarr/bep020
julia-pfarr 205a35f
Update src/modality-specific-files/eye-tracking.md
Remi-Gau cda8874
Apply suggestions from code review
Remi-Gau 8be9429
Update src/schema/objects/columns.yaml
Remi-Gau e6ef2d6
Update src/schema/objects/columns.yaml
Remi-Gau 84b869a
Update metadata.yaml
mszinte 0ca61b4
Merge branch 'master' into bep020
Remi-Gau 53fcd97
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4c7a30f
Update src/schema/objects/metadata.yaml
Remi-Gau 6c2b2f5
fix issues in mkdocs.yml
Remi-Gau 79fd36b
hasty copy paste
Remi-Gau edc81bc
fix time stamp
Remi-Gau fcaaeaa
add placeholder for eventual publication
sappelhoff 0bb5e41
Update metadata.yaml
mszinte c2ca15b
Update src/modality-specific-files/eye-tracking.md
mszinte 632eca2
Update src/modality-specific-files/eye-tracking.md
mszinte 75c0baa
Update src/modality-specific-files/near-infrared-spectroscopy.md
Remi-Gau 05c8227
enh: a proposal for the new ``RecordingType`` (-> ``PhysioType``) idea
oesteban cbd2da7
enh: add eyetracking examples
oesteban 8f90b33
enh: revise metadata specifications
oesteban a1126da
fix: remove duplicated metadata entry
oesteban e728546
restore eyetrack sidecars
oesteban 87e93c1
Merge pull request #8 from oesteban/bep020-proposal
oesteban ef49458
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1d05d11
fix: pacify codespell
oesteban 2920134
fix: pacify markdown linter
oesteban 3636333
fix: attempt to get line numbers on tsv files
oesteban aeac149
fix: attempt 2 to get line numbers on tsv files
oesteban 9df5c4e
Update src/modality-specific-files/eye-tracking.md
oesteban b7d19b2
fix: address several issues, add example datasets, pacify remark
oesteban 8b2e7e5
enh: better ordering, clearer definitions
oesteban 6968915
sty: pacify remark
oesteban b56d7e0
enh: change zero-based to one-base indexes, more consistent with BIDS
oesteban a618326
fix: remove redirected URL
oesteban 57b1737
Merge branch 'master' into bep020
oesteban 12b1abc
enh: add columns definition for physioevents and improve eyetracker e…
oesteban c8d8fc3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 01f820d
fix: length of new message column description
oesteban 61a1f31
fix: improved definition of ForeignIndexColumn
oesteban ea5cc44
Merge branch 'master' into bep020
oesteban 1e188a0
enh: clearly state specific physio types at the outset
oesteban 366cbc9
enh: improving and adding example file trees
oesteban 3b71c1f
fix: normalize file tree macros and repare syntax of some
oesteban e209833
fix: typos and readability improvements
oesteban e9fcd85
review and slight text modification
6f0d8fb
Merge branch 'master' into bep020
Remi-Gau d16fd64
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5ef41f4
Merge remote-tracking branch 'upstream/master' into bep020
oesteban 311b645
fix: revert boilerplate about publication
oesteban 90b9fba
enh: drop "old" eyetrack
oesteban 51d7ae9
fix: ``"cyclopean"`` value for ``RecordedEye`` metadata
oesteban 239f93c
fix: deduplicate example datasets, and move eyetrack's ones into an a…
oesteban f34589c
fix: missing setting eyetrack tabular data allowed to add columns
oesteban 3606735
enh: deep reorganization of the section
oesteban 4aed597
fix: pacify linter
oesteban 3bbe59c
Update src/modality-specific-files/physiological-and-other-continuous…
oesteban 3beafc6
enh: move escalating events' metadata to REQUIRED into task data section
oesteban 8c95b8c
Merge remote-tracking branch 'upstream/master' into bep020
oesteban 96d984e
Merge branch 'master' into bep020
oesteban f57f393
fix unit
Remi-Gau 8b6d458
use levels to describe metadata
Remi-Gau 6aeb1c2
Merge remote-tracking branch 'upstream/master' into pr/mszinte/1128
Remi-Gau e92027c
fix typo
Remi-Gau 26c463a
minor schema fix
Remi-Gau a6a1c9d
Merge branch 'master' into bep020
Remi-Gau 0ad7fb1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a5ea212
fix
Remi-Gau 6e787b6
enh: add @Sourav-Kulkarni's suggestions about eye-tracker/screen dist…
oesteban 9e697d2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 09b40d7
enh: address @qian-chu's review comment about documenting timestamp
oesteban cce40a0
enh: address @Remi-Gau's comment on column order
oesteban 19dab86
Update src/modality-specific-files/physiological-recordings.md
oesteban e222088
Update src/modality-specific-files/physiological-recordings.md
oesteban edaeace
Update src/modality-specific-files/physiological-recordings.md
mszinte a4671fb
fix: address issue of ``EnvironmentCoordinates``
oesteban 9a6c10e
enh: add note about the type of pupil size being recorded
oesteban c040159
enh: document all four columns of physio.json file
oesteban e3c698c
Update src/schema/objects/metadata.yaml
oesteban 97688ec
Merge remote-tracking branch 'upstream/master' into bep020
oesteban 3198a73
fix: remove backtick breaking yaml file
oesteban File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
change after review of tsalo
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assumes the same position for all calibrations / validations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you elaborate on the problem?