Adding micr_XPCTzarr dataset #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Jul 12, 2024
...rr/sub-LADAF-2020-31/ses-01/micr/sub-LADAF-2020-31_ses-01_sample-brain_XPCT.ome.zarr/0/0/0/0
Outdated
Show resolved
Hide resolved
chourroutm
commented
Jul 13, 2024
micr_XPCTzarr/sub-LADAF-2020-31/ses-01/micr/sub-LADAF-2020-31_ses-01_sample-brain_XPCT.json
Outdated
Show resolved
Hide resolved
micr_XPCTzarr/sub-LADAF-2020-31/sub-LADAF-2020-31_sessions.json
Outdated
Show resolved
Hide resolved
dstansby
reviewed
Jul 25, 2024
micr_XPCTzarr/sub-LADAF-2020-31/ses-01/micr/sub-LADAF-2020-31_ses-01_sample-brain_XPCT.json
Outdated
Show resolved
Hide resolved
effigies
reviewed
Jul 25, 2024
correction: typo on diacritic in name
effigies
reviewed
Aug 6, 2024
micr_XPCTzarr/sub-01/ses-01/micr/sub-01_ses-01_sample-brain_photo.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Markiewicz <[email protected]>
…oto.json Co-authored-by: Chris Markiewicz <[email protected]>
|
@bids-standard/maintainers This PR uses a BIDS-URI. These are supported by the schema validator but not the legacy validator. Do we just want to exclude this dataset from legacy validation, or fall back to the subject-relative path? |
+1 to exclude from legacy validation |
|
Did https://github.com/bids-standard/bids-validator/pull/2069 instead. Running locally, only EMPTY_FILES complains: ❯ bids-validator/bin/bids-validator ../examples/micr_XPCTzarr
[email protected]
1: [ERR] Empty files not allowed. (code: 99 - EMPTY_FILE)
./sub-01/ses-01/micr/sub-01_ses-01_sample-brain_XPCT.ome.zarr/0/0/0/0
Please visit https://neurostars.org/search?q=EMPTY_FILE for existing conversations about this issue.
1: [WARN] Tabular file contains custom columns not described in a data dictionary (code: 82 - CUSTOM_COLUMN_WITHOUT_DESCRIPTION)
./samples.tsv
Evidence: Columns: sample_info not defined, please define in: /samples.json
Please visit https://neurostars.org/search?q=CUSTOM_COLUMN_WITHOUT_DESCRIPTION for existing conversations about this issue.
Summary: Available Tasks: Available Modalities:
12 Files, 136.75KB Microscopy
1 - Subject
1 - Session
If you have any questions, please post on https://neurostars.org/tags/bids. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of an example dataset for the XPCT suffix for microscopy in the OME-Zarr (NGFF) file format.