Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deno compile to install deno bids-validator #449

Closed
wants to merge 2 commits into from
Closed

Use deno compile to install deno bids-validator #449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23e2d2a
Use deno compile to install deno bids-validator
yarikoptic Jun 11, 2024
59e9191
Do pushd/popd dance to place bids-validator repo aside
yarikoptic Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/validate_datasets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ jobs:
run: |
LOCAL_BIN=$HOME/.local/bin
VALIDATOR=$LOCAL_BIN/bids-validator
mkdir -p $LOCAL_BIN
export PATH="$LOCAL_BIN:$PATH"
echo PATH="$PATH" >> $GITHUB_ENV
Comment on lines -74 to -76
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing $HOME/.local/bin from the path seems the likely cause of the failure to find the executable.

echo -e '#!/usr/bin/env'" -S deno run --allow-read --allow-write --allow-env --allow-net --allow-run\nimport 'https://github.com/bids-standard/bids-validator/raw/master/bids-validator/src/bids-validator.ts'" > $VALIDATOR
chmod +x $VALIDATOR
# Clone "lean" but with tags for versioning
pushd ..
git clone --filter=blob:none http://github.com/bids-standard/bids-validator
deno compile -o "$VALIDATOR" -A bids-validator/bids-validator/src/bids-validator.ts
popd
bids-validator --version
shell: bash

Expand Down
Loading