-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enh][PET] add example for ReconFilterType is 'none' #427
base: master
Are you sure you want to change the base?
Conversation
Should be fixed in bids-validator@master. Bumping CI. |
"ReconMethodParameterLabels": [ | ||
"none" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, reading the spec, it says
REQUIRED if ReconMethodParameterLabels does not contain "none"
but that seems odd. If it's ["abc", "def", "none"]
, presumably you want units and values. I suppose the text should actually say 'is not ["none"]
'? I can probably do that in schema. Matching any might require me to bug Ross.
What is currently implemented is:
"ReconMethodParameterLabels": [ | |
"none" | |
], | |
"ReconMethodParameterLabels": "none", |
We could update the text to allow that, but I think probably ["none"]
is the cleaner solution, so that the type is constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mnoergaard Would you mind commenting on the original intent here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original intent goes back to the PET guidelines paper (https://journals.sagepub.com/doi/10.1177/0271678X20905433) where the ReconMethodParameterLabels was decided to be mandatory. In most cases, there are multiple reconstruction parameters and labels, however, for some older scanners there no recon parameters. As far as I remember, for the old validator, it was not easy to combine datatypes depending on the need, so it was decided to keep this as an array of strings. However, it is not so clean in the case of no parameters (even with ["none"]. Just "none" would be the cleanest.
e598827
to
676a60f
Compare
Adds an example dataset to help with the closing of this issue -> https://github.com/bids-standard/bids-validator/issues/1897 on the BIDS Validator