-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A collection of small style adjustments #220
Open
stanio
wants to merge
4
commits into
bhollis:master
Choose a base branch
from
stanio:style-oneliners
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amends bhollis#98 with a more reliable declaration ensuring visible ellipsis with any font's normal line height, incl. custom line-height. 'lh' is more recently implemented CSS unit: - https://developer.mozilla.org/en-US/docs/Web/CSS/length#lh - https://developer.mozilla.org/en-US/docs/Learn/CSS/Building_blocks/Values_and_units#line_height_units so keep the original `line-height: 1.2` as a fallback.
- https://developer.mozilla.org/en-US/docs/Web/CSS/word-break Alternative could be: overflow-wrap: break-word; but the former ensures the value starts at the same line as the property name, for example.
Standard metadata names <https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name>: > color-scheme: specifies one or more color schemes with which > the document is compatible. The browser will use this information > in tandem with the user's browser or device settings to determine > what colors to use for everything from background and foregrounds > to form controls and scrollbars. This also adjusts the selection/highlight colors, all CSS system colors: - https://drafts.csswg.org/css-color/#css-system-colors It could prevent "white flashes" in some contexts. The difference with the CSS `color-scheme` property [1] is, for example, with Firefox View > Page Style > No Style it still honors the browser's color theme. [1] https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme
I'll drop these last two from this PR as I'm still tweaking them for myself. |
stanio
force-pushed
the
style-oneliners
branch
from
September 4, 2024 05:54
876dcc6
to
2343862
Compare
This avoids somewhat annoying translucent-background selection overlays. - https://developer.mozilla.org/en-US/docs/Web/CSS/::selection
stanio
force-pushed
the
style-oneliners
branch
from
September 4, 2024 06:11
2343862
to
d8a01e1
Compare
Awesome, thank you! I'll take a look through these and see what can be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are small style adjustments I'm currently using via "user styles". See the individual commit messages for some more details, while I'll leave some Before and After screenshots here:
Give
.collapsible.collapsed { height: 1lh }
Using
#json { line-height: 2 }
:Avoid horizontal scroll with very long string or link values
Firefox breaks somewhat more by default:
Specify
<meta name="color-scheme" content="light dark">
Firefox View > Page Style > No Style:
Force transparent background for "collapsed" text selection
Specify widths/lengths inch
unitEnlarge.collapser
width/click-areaSee if you may be interested in any of these.