Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups #770

Merged
merged 7 commits into from
Apr 1, 2024
Merged

Various cleanups #770

merged 7 commits into from
Apr 1, 2024

Conversation

samueltardieu
Copy link
Contributor

Those various cleanups help ensure a build without warnings:

  • Remove redundant imports
  • Remove unused trait
  • Do not use deprecated "cargo-clippy" feature check
  • Replace objects instead of recreating them
  • Define generic parameter bound in one place only
  • Use Unix end-of-line convention for Rust source files
  • Add missing documentation comment

This makes it easier to check that proposed pull requests do not introduce new warnings themselves.

Lints starting with "clippy::" are already recognized as being
applicable to Clippy only.
`.clone_into()` avoids a whole object deallocation and
reallocation. Flagged by recent Clippy.
@lemmih lemmih merged commit f1ea31a into bheisler:master Apr 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants