Fix gnuplot --version encoding handling on Windows #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueltardieu
approved these changes
Mar 29, 2024
|
@sandersaares If you could rebase your PR on the latest master, this would help to have a clean CI build. |
In some configurations, `gnuplot --version` will emit output as UTF-16 bytes instead of UTF-8. This is not expected by `parse_version()` which always expects UTF-8. This change enhances `parse_version()` with a simple fallback - if UTF-8 parsing fails, it will try again with UTF-16.
sandersaares
force-pushed
the
sasaares/fix-gluplot-win-utf16-handling
branch
from
41dba44 to
ce2f85d
Compare
|
Rebased |
|
@bheisler @lemmih @waywardmonkeys ping for attention. Would love to light up this feature on Windows! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some configurations,
gnuplot --versionwill emit output as UTF-16 bytes instead of UTF-8. This is not expected byparse_version()which always expects UTF-8.This change enhances
parse_version()with a simple fallback - if UTF-8 parsing fails, it will try again with UTF-16.Fixes #570.