-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unwrap()s from context.rs #26
Conversation
Thanks for the pull request! It might be a while before I can review this properly. |
src/context.rs
Outdated
//! } | ||
//! CurrentContext::set_current(&contexts[0])?; | ||
//! | ||
//! // Call Rustacuda functions which will use the context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rustacuda should be RustaCUDA, as it was before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it looks like the indentation of this example was changed. Was that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I just lifted it from your comment as that one was a little hard for me.
For the most part this looks good, but there are a bunch of minor things that will need to be cleaned up.
Other comments:
|
Should I just refork your repo & then submit a new pull request, once I've made those cleanups and possibly others? |
No, just push more commits fixing the issues I raised in my review. You may want to read up on the |
Whoops, while messing around with git I accidentally closed this. |
This should be good to go. If it's acceptable, I'll start working on the other |
I split up device.rs, so make sure to pull from master before doing that
…On Tue, Dec 25, 2018, 5:34 PM Jeremy Francis ***@***.*** wrote:
This should be good to go.
If it's acceptable, I'll start working on the other unwrap() calls in
device.rs etc ~
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKUNKKdS1eAjA8kANlt6Q9MGzVKezsL4ks5u8rYNgaJpZM4ZfT9i>
.
|
Thanks for the pull request! |
I removed all the ones I could.
cargo test --doc
97 Passes, 2 Ignored, 0 Failing.Hope it's acceptable.