Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @safe-global/safe-apps-react-sdk from 4.6.4 to 4.7.0 #541

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 11, 2023

Bumps @safe-global/safe-apps-react-sdk from 4.6.4 to 4.7.0.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 11, 2023
@bh2smith
Copy link
Owner

I can't seem to bump any of the Safe dependencies currently as there appears to be an issue with viem. I tried what was suggested here (i.e. updating a specific line in a dependency file - locally) and it did not resolve the issue.

https://stackoverflow.com/questions/19697858/referenceerror-textencoder-is-not-defined

Have you run into this before @schmanu ?

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/safe-global/safe-apps-react-sdk-4.7.0 branch from 0c0a6e6 to 134dc91 Compare August 11, 2023 09:17
@dasanra
Copy link

dasanra commented Aug 24, 2023

@bh2smith for us it was an issue with Jest not having that function polyfilled, so tests were breaking. This is a known issue with Jest. They plan to solve in future versions, but nothing so far.

https://github.com/safe-global/safe-react-apps/pull/746/files#diff-b87029df2904131d749ee08cfe605ee6fe69253a53b2faf395bfc1fe0f8464ebR3

In your case was it an issue with testing or something else?

@bh2smith
Copy link
Owner

Thanks @dasanra - it was an issue running tests yes. I haven't looked super close but that sounds about right.

Bumps @safe-global/safe-apps-react-sdk from 4.6.4 to 4.7.0.

---
updated-dependencies:
- dependency-name: "@safe-global/safe-apps-react-sdk"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@bh2smith bh2smith force-pushed the dependabot/npm_and_yarn/safe-global/safe-apps-react-sdk-4.7.0 branch from 134dc91 to b86fe0f Compare December 3, 2023 10:57
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 1, 2024

A newer version of @​safe-global/safe-apps-react-sdk exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@schmanu
Copy link
Collaborator

schmanu commented Jun 9, 2024

Closing in favor of #597 which updates this package.

@schmanu schmanu closed this Jun 9, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 9, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/safe-global/safe-apps-react-sdk-4.7.0 branch June 9, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants