Generator update permissioned payloads controller #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 15, 2024 13:17
added 7 commits
November 18, 2024 11:49
add: new version of EmissionTestMATICXPolygon.t.sol
generator/templates/liquiditymining.payloaddeployment.template.ts
Outdated
Show resolved
Hide resolved
|
@Cycxyz The generator seems to be breaking when custom reward asset is passed |
|
Also can you update the readme, explaining in detail how the new flow would be with clear instructions - ex. running the tests for validation and using the scripts to register the payloads and so on. |
added 2 commits
November 22, 2024 11:32
…ayloadsContrller fix add: test command and deploy script command
generator/templates/liquiditymining.payloaddeployment.template.ts
Outdated
Show resolved
Hide resolved
generator/templates/liquiditymining.payloaddeployment.template.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Harsh Pandey <[email protected]>
| * or | ||
| * make deploy-private-key contract=scripts/EmissionMATICXPolygonConfigurationDeploy.s.sol chain=polygon private_key=$\{PRIVATE_KEY\} | ||
| */ | ||
| contract EmissionMATICXPolygonConfigurationDeploy is |
There was a problem hiding this comment.
This file is generated in the tests folder no?
Also there are some example tests using the older flow in tests directory, I would replace them with some examples from new payloadsController flow (we can do that once we have the contracts deployed too)
* chore: fix remappings * fix: compile fix * Revert "fix: compile fix" This reverts commit 5426104. --------- Co-authored-by: Vladyslav Burtsevych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temp changes
needed to add dependencie to deploy PermissionedPayloadsController. Dependency has to be removed when PermissionedPayloadsController will be deployed.
foundry recursive auto-detected dependencies fix. Changes will be reverted after aave-v3-governance dependency removed
What was made
Old tests were adopted to return IPayloadsControllerCore.ExecutionActions[] object. This object has to be passed to PermissionedPayloadsController by PAYLOADS_MANAGER address as payload. Now tests also responsible for deploying PermissionedPayloadsController. That functionality has to be removed later, after deploying controller