Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aave ParaSwap Adapters #27

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Aave ParaSwap Adapters #27

wants to merge 6 commits into from

Conversation

miguelmtzinf
Copy link
Contributor

Based on the approach used for ParaSwapDebtAdapter by @bgd-labs, Aave Labs created a new version of the existing ParaSwap adapters of V3 with enhanced logic and usability.

This PR:

  • Add adapter contracts for the following actions: repay with collateral, collateral swap and withdraw and swap.
  • Add details about ParaSwap integration and security considerations.
  • Reorder directory structure, including contracts and tests.
  • Fix natspec docs and add clean-ups across contracts.

Looking forward to BGD's feedback on these contracts, and how we can collaborate together on this matter

sakulstra
sakulstra reviewed Feb 29, 2024
View reviewed changes
foundry.toml Show resolved Hide resolved
scripts/psp.js Show resolved Hide resolved
scripts/psp.js Outdated Show resolved Hide resolved
src/contracts/ParaSwapLiquiditySwapAdapterV2.sol Show resolved Hide resolved
src/contracts/base/ParaSwapLiquiditySwapAdapter.sol Outdated Show resolved Hide resolved
src/contracts/base/ParaSwapLiquiditySwapAdapter.sol Show resolved Hide resolved
@parth-15 parth-15 mentioned this pull request Mar 6, 2024
Merged
@miguelmtzinf miguelmtzinf mentioned this pull request Mar 7, 2024
Closed
parth-15 added 2 commits March 7, 2024 14:11
@parth-15
fix: rename variable in psp.js (#14)
ac087c4
@parth-15
fix: move common function to base contract (#13)
cb77b7f 
* fix: move common function to base contract

* fix: make allowance function internal

* remove redundant function
@miguelmtzinf
Copy link
Contributor Author

Complicated to fix existing conflicts given that this PR performs major changes in files and directories structure. @sakulstra lmk what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parth-15 parth-15 parth-15 left review comments

@sakulstra sakulstra sakulstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelmtzinf @sakulstra @parth-15