Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server error banned login #302

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Fix server error banned login #302

merged 4 commits into from
Jun 3, 2024

Conversation

geekingfrog
Copy link
Contributor

Fix #253 (and #301 which is a duplicate).

@geekingfrog
Verify ban status at login
49a0c24 
Instead of doing that only in a plug.
@geekingfrog
Fix syntax for redirect
2fc6283 
Also clear any session cookie, as that may cause an infinite redirect
loop.
@geekingfrog geekingfrog marked this pull request as ready for review May 30, 2024 20:25
StanczakDominik
StanczakDominik approved these changes Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've deployed it on server5, tested, and it just works 👌🏻 this is amazing, thank you! That's one less annoying copypasta we have to carry around 😁

If you find those proposed messages clear and understandable, we can just merge it right away :)

lib/teiserver/account/libs/user_lib.ex Outdated Show resolved Hide resolved
lib/teiserver/account/libs/user_lib.ex Outdated Show resolved Hide resolved
geekingfrog and others added 2 commits June 3, 2024 07:32
@geekingfrog @StanczakDominik
Better smurf detected message
d13877b 
Co-authored-by: Dominik Stańczak-Marikin <[email protected]>
@geekingfrog @StanczakDominik
Better banned message
74b4ca6 
Co-authored-by: Dominik Stańczak-Marikin <[email protected]>
@geekingfrog
Copy link
Contributor Author

Cool, ship it \o/

@StanczakDominik StanczakDominik merged commit 8549962 into beyond-all-reason:master Jun 3, 2024
1 check failed
@StanczakDominik StanczakDominik mentioned this pull request Jun 3, 2024
Closed
@geekingfrog geekingfrog deleted the fix-server-error-banned-login branch June 3, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanczakDominik StanczakDominik StanczakDominik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better message when suspended from logging in
2 participants
@geekingfrog @StanczakDominik