Fix DGun Stall Assist widget not waiting factories

[Prehistoricman]

Work done

• Fixes dgun stall assist widget not waiting factories
• Remove need to hardcode all units that can d-gun (uses canManualFire property)
• Reduce 'watch' time (5s to 3s) so that units come back online quicker
• Avoid waiting units that don't build things (such as the Arm EMP spider)

Since this widget will now wait any unit that has buildpower, I looked through the list of affected units and found some that we don't want to wait (the exceptions table). I chose the spy bots, EMP spider, and anti-nuke ships. But perhaps the spy bot choice is contentious: it uses more power when moving and the script could stop it. What do you think?

Addresses Issue(s)

• https://discord.com/channels/549281623154229250/1278497565507326012

Setup

1. Enable "DGun Stall Assist" widget
2. Build a factory and a worker

Test steps

1. Fire d-guns until energy stalling
2. Expect that both the factory and worker are given a WAIT command by the widget

[saurtron]

• Remove need to hardcode all units that can d-gun (uses canManualFire property)

Problem here is some other unit(s?) also have canManualFire (like thor, armseadragon, cordesolator) and more could pop up without notice. Not sure that's a problem here, but probably needs to be considered.

Maybe can check for other unit attributes, like, customParams.iscommander seems the way to go. Otherwise, things like does it actually have a dgun, or other commander-like attributes.

[saurtron]

maybe add legion units too?

[Prehistoricman]

Do you have any in mind? I have screened the units added by this change and the few legion ones all look valid.

[saurtron]

Not really, I just said because I see a few arm and core ones there and thought there might be similar ones, but also not very familiar with legion units. If you checked then I guess it's ok.

[sprunk]

Perhaps ideally it would work for any manual fire but appropriately to the cost? So if commander DGun costs 600e it interrupts stuff if you have less than 600e, but if Thor or cordesolator cost 0e it will only interrupt stuff if you have less than 0e.

[Prehistoricman]

Thanks for the review guys.

Problem here is some other unit(s?) also have canManualFire (like thor, armseadragon, cordesolator) and more could pop up without notice. Not sure that's a problem here, but probably needs to be considered.

Maybe can check for other unit attributes, like, customParams.iscommander seems the way to go. Otherwise, things like does it actually have a dgun, or other commander-like attributes.

I gave those a test and they don't trigger the assist because the command given is not CMD.DGUN, so that's OK. iscommander is not true for the decoy commander, which you may consider OK or not OK.

Perhaps ideally it would work for any manual fire but appropriately to the cost? So if commander DGun costs 600e it interrupts stuff if you have less than 600e, but if Thor or cordesolator cost 0e it will only interrupt stuff if you have less than 0e.

That sounds like an ideal solution. Can you outline how I would do that? I can see that the weapon def has "commandfire = true" but I don't see how to access that from the widget.

[sprunk]

commandfire is read back as manualfire from widgets. and energy per shot is energyCost.

[Prehistoricman]

commandfire is read back as manualfire from widgets. and energy per shot is energyCost.

Thanks. Done and tested with the decoy commander.