-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projectile overrange unit implementation #4124
base: master
Are you sure you want to change the base?
Projectile overrange unit implementation #4124
Conversation
explodeas = "smallexplosiongeneric", | ||
footprintx = 2, | ||
footprintz = 2, | ||
health = 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't have reorganized alphabetically as part of the same PR. That makes the pr more difficult to review, and also pollutes git history.
Ok I see it's because of some tool, but git allows adding just some of the stuff (git add -p). Anyways not a big deal.
@@ -1,11 +1,7 @@ | |||
return { | |||
armcomlvl2 = { | |||
maxacc = 0.18, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file doesn't look like it should be part of the commit, right?
looking at the changes imo that method should be forbidden XD, would have been better to just edit manually or even code postprocess. |
Yes. |
That examples remakes all keys to lowercase, but not sure bar is doing that (guess it is tho). Doesn't seem like a very good idea, now everyone changing capitalization randomly just in case. |
Read the text of the article and not just the example. tl;dr:
|
Do not use Unitdef baking. |
Adds overrange to StarburstLauncher/MissileLauncher units to prevent overrange. It's +10% of unitdef.range. This PR includes legion units. AA units are excluded.
The legion unitdefs are pretty terribly un-alphabetized so there's alot of changes being that I used the unit bake method of adding these customparams to units