Tweaks and improvement to declutter defense-ranges (2nd attempt)

[WatchTheFort]

From @icexuick in the original PR #3732:

And removal/integration of old defense-ranges + anti-ranges into new gl4 defense-ranges.

This is a new and tweaked version of the Defense-Ranges Widget.
It is meant to replace the old Defense Ranges.

What needs to be checked but also fixed/added is this:

gui_defenserange_gl4

1. Show the range rings on mouse-hover on the minimap.
2. Add underwater weapons (torpedoes) as blue rings
3. Make cannon (LRPC) range rings disappear on distance (anti-nukes works correct, cannon does not - it remains visible)
4. Add different pulsating color/fade to anti-nukes (allied) that have 0 stockpile - code of gui_anti_ranges.lua should probably be merged into gui_defenseranges_gl4.lua

gui_attackrange_gl4

1. Separate "cannon" to only LRPC - (only for cannons that shoot over f.e. 2000 range - now it's gets assigned to practically all plasma cannons)
2. Consider adding blue underwater weapons here as well
3. Be able to manually choose which units show firing arcs, and which don't - some have quite some overlapping/confusing arcs which should be removed - while others (like armmanni or cormart) visually explain their firing-arc very well, and not too cluttering)
4. LRPC now actually show their range on hover because of separate "cannon" settings (only needs to be added to minimap for ideal solution)

New zoomed out view with added LRPC cannons (yellow/orange) and anti-nukes (light-blue)

New zoomed in view on defense ranges with much less clutter:

PS. Also added as much Legion defenses as possible - but needs checking.

[WatchTheFort]

#3732 had to be reverted because it broke range circles. This PR replaces it, as in Github merged PRs cannot be reopened.

[ZephyrSkies7]

T1 LLT (leglht) and T1 arty (legcluster) are missing from this list.

[icexuick]

what weapon types do leglht and legcluster have?
0 = default / land/ground based weapon
1 = AA
2 = anti-nuke
3 = long-range artillery

[ZephyrSkies7]

leglht should be 0, it's just the LLT equivalent. Pretty sure legcluster is also 0 since it's a short range arty as an equivalent to the Agitator and Gauntlet.

EDIT: Apologies if this comment in particular is preventing a merge, please mark as resolved at your discretion

[ZephyrSkies7]

With the thicker range lines across the board, increasing the visibility and prevalence of radar rings might be worth consideration. Could look considerably more camouflaged on predominantly grassy maps.

[icexuick]

Grass + radar
Attack + red rock
Sonar + water
They remain tricky.

There are solutions like saturation or increased thickness, though they are hard to balance well and to still not clutter.
I would love some configuration for this before merging, meaning some extra settings for these.
Iirc these are not in the settings menu in this PR.

[icexuick]

These were some errors posted by CMDR*Zod

[t=01:30:48.582621][f=0001781] LuaShader: [Attack Range GL4] shader error(s):
0:11011(9): error: no matching function for call to `texture(sampler2D, vec2, float)'; candidates are:

[t=01:30:48.584726][f=0001781] Attack Range GL4,  recompiled in , 6, ms at, 1781, success, false
[t=01:30:48.584738][f=0001781] AttackRange GL4 widget exiting with reason: Failed to compile attackRangeShader GL4 ```

[Beherith]

Grass + radar Attack + red rock Sonar + water They remain tricky.

There are solutions like saturation or increased thickness, though they are hard to balance well and to still not clutter. I would love some configuration for this before merging, meaning some extra settings for these. Iirc these are not in the settings menu in this PR.

1. I do not understand the list above
2. These should not be user configurable, keep user config to an absolute minimum. Configure them in the widget.
3. I fixed the shader errors

[Beherith]

#3732 had to be reverted because it broke range circles. This PR replaces it, as in Github merged PRs cannot be reopened.

Broke, how so? Got links?

[WatchTheFort]

Broke, how so? Got links?

https://discord.com/channels/549281623154229250/1319694808486252584

[sprunk]

I do not understand the list above

Since radar circle is green, the circle is hard to see on grass which is also green - it blends into the terrain.
Ditto for attack range, whose red circle is hard to see on "Mars" style red terrain.

[icexuick]

@ZephyrSkies7 could you provide the weapontypes for the 2 missing Legion defenses?

[keelefi]

I started testing this and the widget "Attack Range GL4" no longer crashes.

However, I found a bug: Build an Armada bot lab. Start building a constructor bot and select the constructor while it's building. The build range of the constructor should show. Wait for the constructor to finish building. The build range of the constructor disappears. (You can get the build range of the constructor back by deselecting and reselecting the finished constructor)

I'm also not a fan of the LLT ranges not being shown when not selected, but that's a game design decision and I'm not part of the game design team.

P.S. please give your git branches sensible names and don't use & as part of the name:

$ git fetch beyond-all-reason New-Defense-Ranges-GL4-/-Removal-of-old-&-anti-ranges
[1] 13765
-anti-ranges: command not found