-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Naga 0.19 #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
thanks! yeah i agree the ci failures are not related. i am not sure what's going on, will investigate properly for the next naga release. |
Dinnerbone
force-pushed
the
naga_0_19
branch
2 times, most recently
from
January 17, 2024 20:31
d44bfaa
to
79a62d1
Compare
PR is now up to date with 0.19 Locally I experienced a test failure but I can't get it to happen again. Hard to say if it's naga, naga_oil or something else at fault.
|
mockersf
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It comes out on the 17th hopefully, so opening this now to hopefully get an easy update. Will undraft on release,Also sneakily includes a fix for a new version of
cargo fmt
that came out since the last time it was ran on this project.Tests work on my machine (windows) but CI fails on Ubuntu for... unknown reasons. I don't think it's related to this PR.