Code

StandardMaterial Light Transmission#8015

Code

Merged

cart merged 229 commits intobevyengine:mainbevyengine/bevy:mainfrom coreh:transmissioncoreh/bevy:transmissionCopy head branch name to clipboardOct 31, 2023

+1,977-60

Commits

Commits on Mar 8, 2023

• Expose both main Textures and TextureViews in ViewTarget.

  coreh

  committed
  140f0c4

• Introduce ViewTransmissionTexture

  coreh

  committed
  d068a57

• Expose ViewTransmissionTexture in mesh view uniforms

  coreh

  committed
  52233b3

• Copy main texture to transmission texture before transparent phase

  coreh

  committed
  675913d

• Add missing use items

  coreh

  committed
  af53dfe

• Add rudimentary light transmission implementation in PBR shader

  coreh

  committed
  3e0ef1a

Commits on Mar 10, 2023

• Clean up light transmission shader implementation with more proper math/parameters

  coreh

  committed
  b1d4667

• Move transmissive_light() function to pbr_lighting.wgsl

  coreh

  committed
  2999947

• Enable filtering for transmission texture

  coreh

  committed
  d0265bc

• Use consistent naming to refer to the view transmission texture

  coreh

  committed
  714f40a

• Fix comment capitalization

  coreh

  committed
  12b845a

• Expose transmission-related properties in StandardMaterial

  coreh

  committed
  c0ec1e3

• Make transmitted light blurry when material is rough, using dither + multiple taps

  coreh

  committed
  e040fc8

• Unconditionally import tonemapping utils, ensuring dither is present

  coreh

  committed
  c9db7aa

• Add transmission example

  coreh

  committed
  27c9285

• Make number of taps increase faster with perceptual roughness

  coreh

  committed
  13f59bf

• Tweak initial camera position

  coreh

  committed
  24359e6

• Remove redundant else branch

  coreh

  committed
  dc0b25d

Commits on Mar 25, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  93377bc

• Fix deprecation warning

  coreh

  committed
  4c408d0

Commits on Mar 27, 2023

• Improve refraction math by propagating refracted ray through world space, then projecting to view

  coreh

  committed
  bb69138

• Tweak transmissive background blur so that it looks correct with the improved math

  coreh

  committed
  7a2752c

Commits on Apr 9, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  fb49029

Commits on Apr 10, 2023

• Split Transmissive3d into a separate pass

  coreh

  committed
  3bc0a01

• Remove redundant clone

  coreh

  committed
  41a74c0

• Rename transmissive to is_transmissive

  coreh

  committed
  d158e73

• Add missing example link to examples/README.md

  coreh

  committed
  2458e8f

Commits on Apr 15, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  0a11954

• Add diffuse_transmission property to StandardMaterial

  coreh

  committed
  0feafb2

• Allow transmission with AlphaMode::Opaque materials

  coreh

  committed
  cfd5859

Commits on Apr 16, 2023

• Add second Lambertian lobe-based diffuse transmission to PBR shader

  coreh

  committed
  e2b816b

• Add ability to independently suppress shadows in diffuse transmission lobe

  coreh

  committed
  927cfa2

• Add update example showcasing both diffuse and specular transmission

  coreh

  committed
  cd1976d

• Tweak camera height and enable HDR by default

  coreh

  committed
  fa26e79

• Make candle light and flame flicker

  coreh

  committed
  18bfd50

• Fix lint error

  coreh

  committed
  0827aa1

• Fix documentation link

  coreh

  committed
  b7a6ff4

• Fix additional documentation links

  coreh

  committed
  08e7416

• Add transmission, thickness and diffuse transmission textures

  coreh

  committed
  272b696

• Add ability to load transmission, thickness and ior from glTF

  coreh

  committed
  1747412

• Add support for a configurable number of transmissive steps

  coreh

  committed
  727a89d

• Increase all_tuples limit to avoid error in queue_mesh_view_bind_groups

  coreh

  committed
  5d7f619

• Scale thickness with mesh transform (using average of X, Y and Z scales)

  coreh

  committed
  13b1e59

• Introduce FallbackImageZero

  coreh

  committed
  294a677

• Fallback to (specular) transmitted environment light when there's no transmitted background

  coreh

  committed
  5bfe6bb

• Make refraction math for environment map more accurate

  coreh

  committed
  fd65d4b

• Update example to showcase transmissive steps option

  coreh

  committed
  e911b58

• Limit transmissive steps to 4, as there are only four transmissive objects

  coreh

  committed
  2ffc871

• Fix lint error

  coreh

  committed
  545019a

• Improve documentation for Camera3d::transmissive_steps

  coreh

  committed
  0dadf4e

• Add documentation aliases

  coreh

  committed
  ef04bad

• Improve diffuse_transmission documentation

  coreh

  committed
  c38255e

• Merge branch 'main' into transmission

  coreh

  committed
  adf2f0f

Commits on Apr 19, 2023

• Use depth prepass data to reject values that are in front of the current fragment

  coreh

  committed
  b1db977

• Add ability to toggle Depth Prepass to example

  coreh

  committed
  3d55cce

Commits on Apr 25, 2023

• Add attenuation_distance and attenuation_color material attributes

  coreh

  committed
  23711c8

• Modify fog functions to take fog as an argument

  coreh

  committed
  50b32da

• Reuse fog implementation to implement transmission attenuation

  coreh

  committed
  580f4af

• Hook up attenuation distance and color to glTF loader

  coreh

  committed
  948bced

• Merge branch 'main' into transmission

  coreh

  committed
  3862e82

• Update section on texture packing

  coreh

  committed
  e25b7fe

• Update index of refraction docs

  coreh

  committed
  95a15d5

• Correctly use min() instead of max() to avoid 300 texture taps

  coreh

  committed
  94e3099

Commits on Apr 26, 2023

• Use interleaved_gradient_noise() instead of screen_space_dither()

  coreh

  committed
  a0535de

• Clear motion vector to 0.0, fixing artifacts against the background

  coreh

  committed
  8ac3ef1

• Add one more sample offset

  coreh

  committed
  d47fe5b

• Add additional quality tweaks to mask the firefly artifacts

  coreh

  committed
  5f2516d

• Enable TAA by default in example

  coreh

  committed
  8d39b8a

• Mention TAA being tied to Depth Prepass in instructions

  coreh

  committed
  ae687eb

Commits on May 2, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  447a0a1

Commits on May 11, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  20b223c

• Add TAA shaderdef, don't vary noise with time if TAA is disabled

  coreh

  committed
  0d817e0

• Allow multiple rotated spiral taps, extract max taps constant

  coreh

  committed
  44da726

• Only compute interleaved_gradient_noise() once

  coreh

  committed
  0dbec52

• Make number of taps increase faster with blur intensity

  coreh

  committed
  54cfc26

• Make blur 50% less blurry

  coreh

  committed
  c81c57c

• Move pixel mesh out of loop, don't vary it by frame if TAA is disabled

  coreh

  committed
  a1e06c7

• Make blur radius scale correctly with distance

  coreh

  committed
  1b33381

• Tweak color normalization to work properly with new blur intensity calculation

  coreh

  committed
  dfd204a

• Remove note about conditionally disabling normalization with TAA (doesn't work very well)

  coreh

  committed
  9650ee9

• Tweak how fast number of taps grows with blur intensity

  coreh

  committed
  721ce68

• Rename sample offsets to spiral offsets for clarity, use upper case naming convention

  coreh

  committed
  cd3e7f1

• Make each consecutive spiral smaller

  coreh

  committed
  da772b8

• Reduce MAX_TRANSMISSIVE_TAPS to 16

  coreh

  committed
  cc22775

• Grow amount of taps slightly faster with intensity

  coreh

  committed
  16c3d04

Commits on May 17, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  0ef74ed

Commits on May 20, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  e2b76ae

Commits on May 28, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  5214260

• Hold both TextureViews and Textures on MainTargetTextures

  coreh

  committed
  0a47196

• Clear motion vector to 0.0, fixing TAA artifacts against the background

  coreh

  committed
  eadb217

• Expose TAA as a shader def

  coreh

  committed
  348e2ce

• Introduce FallbackImageZero

  coreh

  committed
  a12419d

• Add RenderPhase<I>::render_range() method

  coreh

  committed
  77b94e4

• Take fog as an argument instead of relying on fog uniform

  coreh

  committed
  a39364f

• Define E constant in bevy_pbr::utils

  coreh

  committed
  b5ddbd7

• Allow usage of main textures as copy sources

  coreh

  committed
  ac820b4

• Bump system tuple param limits

  coreh

  committed
  b6e564a

• Merge branch 'before-transmission' into transmission

  coreh

  committed
  d17871d

• Apply PR feedback

  coreh

  committed
  cec61c9

Commits on May 29, 2023

• Revert "Bump system tuple param limits"

  Show description for 0aac272
  coreh

  committed
  0aac272

• Rename argument to avoid accidental confusion with uniform

  coreh

  committed
  6103ec0

• Use Option<CachedTexture> type, making invalid states not representable

  coreh

  committed
  e61f78d

• Do not silently ignore out of bounds ranges

  coreh

  committed
  2106a53

• Merge branch 'before-transmission' into transmission

  coreh

  committed
  d756c0d

• Consolidate *-Meta resources in a tuple to avoid deriving SystemParam

  coreh

  committed
  5affd29

Commits on Jun 1, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  96c36ef

Commits on Jun 3, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  68b0e5d

Commits on Jun 6, 2023

• Apply PR feedback to documentation

  coreh

  committed
  c15bd4a

• Rename is_transmissive to reads_view_transmission_texture

  coreh

  committed
  d95d580

• Add comments about transmissive steps

  coreh

  committed
  f798c16

• Add note about future heuristics

  coreh

  committed
  14d4a85

Commits on Jun 7, 2023

• Add shaderdef preventing crash on WebGL for non-transmission examples

  coreh

  committed
  6573485

Commits on Jun 19, 2023

• Add capabilities-based depth texture ifdef guards

  coreh

  committed
  fa57d38

Commits on Jun 20, 2023

• Gate StandardMaterial transmission-related textures behind the pbr_transmission_textures feature flag

  coreh

  committed
  5d75225

• Add guards to enable transmission example to run under WebGL

  coreh

  committed
  1ebe0f7

• Merge branch 'main' into transmission

  coreh

  committed
  efc935d

• Only add NORMAL_PREPASS key to meshes that participate in prepass

  coreh

  committed
  f698949

• Move transmissive prepass check earlier in queuing function for consistency

  coreh

  committed
  f221d31

• Add pbr_transmission_textures to cargo features documentation

  coreh

  committed
  a51352d

• Update comment to match new ambient_light() occlusion argument type

  coreh

  committed
  716b6ba

Commits on Jul 18, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  c353b41

• Qualify module path of functions and bindings

  coreh

  committed
  3e9f74d

• Use .add_plugins() instead of .add_plugin()

  coreh

  committed
  d38aec1

• Simplify PREPASS_DEPTH_SUPPORTED shader def logic, remove conditional #define

  coreh

  committed
  592a6c9

• Add additional module path qualification

  coreh

  committed
  a48a313

• Add note about average being calculated to scale thickness

  coreh

  committed
  cbafe43

• Remove redundant mut

  coreh

  committed
  3542dc0

Commits on Jul 26, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  eb41464

• Replace TAA shader def with TEMPORAL_JITTER

  coreh

  committed
  25147d4

• Rename temporal_noise to temporal_jitter for consistency

  coreh

  committed
  5e7ae92

• Also remove/insert TemporalJitter when toggling DepthPrepass

  coreh

  committed
  4e75436

Commits on Sep 21, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  9608094

• Add missing instance index

  coreh

  committed
  9189f49

• Add Transmissive3d entities to prepare_mesh_uniforms()

  coreh

  committed
  420b6d6

• Fix TemporalJitter import

  coreh

  committed
  d3d73ec

• Mirror loading logic from other textures

  coreh

  committed
  a5ba675

Commits on Sep 24, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  c157a25

• Make Transparent3d phase work again with batching changes

  coreh

  committed
  4c0b6a1

• Improve/fix comments based on PR feedback

  coreh

  committed
  12c2d43

• Add missing min_filter

  coreh

  committed
  e3487e3

• Add a material flag to enable attenuation, removing need for non-portable infinity use

  coreh

  committed
  0adc5da

• Remove mentions of texture packing

  coreh

  committed
  2da4542

• Use view_z to scale specular transmission blur

  coreh

  committed
  45a37eb

• Tweak camera controls, move roughness to E/R

  coreh

  committed
  1edab11

• Flip horizontal camera controls

  coreh

  committed
  f02bba3

• Rename pixel_mesh to pixel_checkboard, improve comments

  coreh

  committed
  46715e6

• Use default font in example

  coreh

  committed
  20bced8

• Make pbr_transmission_textures description shorter, update docs

  coreh

  committed
  8a17bb7

• Add comment on disabled MSAA

  coreh

  committed
  15ebf76

Commits on Sep 26, 2023

• Rename transmission to specular_transmission

  coreh

  committed
  e973e17

• Remove outdated TODO comment

  coreh

  committed
  6558dbb

• Inline spiral values, use a fixed number of taps for now (for loop unrolling)

  coreh

  committed
  d4cc7b8

• Add TransmissiveQuality enum to control number of taps

  coreh

  committed
  e2b017f

• Add transmissive quality controls

  coreh

  committed
  0b51e12

• Add missing use statement

  coreh

  committed
  f2b34dc

• Fix indentation of comments

  coreh

  committed
  3dfe796

• Add a fast codepath for fetching background with zero roughness

  coreh

  committed
  1e4e4f7

• Fix spiral scaling calculation to not leave a hole

  coreh

  committed
  ca62069

Commits on Oct 8, 2023

• Apply PR feedback to documentation

  coreh

  committed
  fd58c77

• Use full channel names instead o R/G/B/A

  coreh

  committed
  3925745

• Apply additional feedback on names and comments

  coreh

  committed
  5fe0258

• Apply additional renames for consistency

  coreh

  committed
  e4d133a

• Rename the blur taps shader def

  coreh

  committed
  5c4f00b

• Simplify blur taps code to use a nested match expression

  coreh

  committed
  14e3753

• Use SCREEN_SPACE_SPECULAR_TRANSMISSION_* name (kinda verbose?)

  coreh

  committed
  30eec56

• Apply feedback to comments

  coreh

  committed
  1d68885

• Update name left behind by previous refactor

  coreh

  committed
  94e1557

• Additional improvements and PR feedback on comments

  coreh

  committed
  0296023

• Improve comment about switch statement

  coreh

  committed
  402518f

• Use De Morgan's laws to make #[cfg()] more readable

  coreh

  committed
  f8db1a6

• Apply feedback to demo

  coreh

  committed
  7231b0c

• Consolidate controls and display in the same UI element

  coreh

  committed
  3b6a8ca

• Improve camera initial position, limit distance

  coreh

  committed
  1099a42

• Do not prepare transmission texture if there are not transmissive items to render

  coreh

  committed
  6742c5d

• Replace Option<With<T>> with Has<T>

  coreh

  committed
  c8b1923

Commits on Oct 9, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  32e9a9c

• Do not override shadow map size

  coreh

  committed
  5d317f4

• Use a smaller shadow map resolution

  coreh

  committed
  8cab969

• Update features documentation

  coreh

  committed
  4a36cb7

• Rename more instances of transmission to specular transmission

  coreh

  committed
  29691db

• Fix shader compilation error when running with pbr_transmission_textures flag enabled

  coreh

  committed
  21cddc6

• Allow clippy::type_complexity in transmission example

  coreh

  committed
  6b76ada

Commits on Oct 11, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  c8e1097

Commits on Oct 15, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  59c9bcd

• Use new WEBGL2 shader def, remove PREPASS_DEPTH_SUPPORTED shader def

  coreh

  committed
  912defb

Commits on Oct 18, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  50faf11

• Properly pass reads_view_transmission_texture() through ExtendedMaterial

  coreh

  committed
  d4ad625

• Fix clippy error

  coreh

  committed
  4e4d790

• Fix documentation links

  coreh

  committed
  42eaf1b

Commits on Oct 19, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  af291b1

• Extract transmission functions to their own file

  coreh

  committed
  6e6f283

• Fix bad merge, replace frag_coord with mesh.position

  coreh

  committed
  dff2f3f

• Extract interleaved_gradient_noise() to utils.wgsl

  coreh

  committed
  2e226bf

• Extract spiral offsets as constants

  coreh

  committed
  27faa49

Commits on Oct 20, 2023

• Revert portion of commit that accidentally included TAA PR changes

  Show description for 4ed2100
  coreh

  committed
  4ed2100

• Use saturate() instead of clamp(_, 0.0, 1.0)

  coreh

  committed
  b44f2a3

• Add missing comments about bind group layout entries

  coreh

  committed
  0a89ee2

Commits on Oct 21, 2023

• Take reflectance into account when calculating specular transmission

  coreh

  committed
  964340c

• Add reflectance controls to transmission example

  coreh

  committed
  7064f98

• Make comment a little bit more clear/consistent with code

  coreh

  committed
  70cb302

• Reorder spiral indexes for better results at lowest quality

  coreh

  committed
  08acedb

• Merge branch 'main' into transmission

  coreh

  committed
  21da603

• Cleanup imports to use new Rust-like syntax

  coreh

  committed
  7832f8e

• Improve documentation comment based on PR feedback

  coreh

  committed
  7a273ae

• Use an associated constant to disable automatic batching for Transmissive3d

  coreh

  committed
  bffc330

• Account for non-uniform scaling when scaling the thickness

  coreh

  committed
  f3281b3

• Add separate controls for TAA and Depth Prepass

  coreh

  committed
  9f00def

• Properly reject values in front of fragment in fetch_transmissive_background_non_rough()

  coreh

  committed
  9fe2599

• Add auto camera movement to example

  coreh

  committed
  7230601

Commits on Oct 25, 2023

• Merge branch 'main' into transmission

  coreh

  committed
  8ac35c2

• Use OpaqueRendererMethod::Forward instead of Auto when diffuse_trasnmission is enabled

  coreh

  committed
  553a5cf

• Make transmitted shadows opt-in rather than opt-out

  Show description for c669389
  coreh

  committed
  c669389

• Fix the handling of AlphaMode::Mask(_) materials with transmission

  coreh

  committed
  a64be59

Commits on Oct 28, 2023

• Remove redundant #ifndef WEBGL2s

  coreh

  committed
  4b96679

• Include mention to Bloom in HDR toggle

  coreh

  committed
  dc2f593

• Add approximate_inverse_tone_mapping() and use it to improve non-HDR results

  coreh

  committed
  3308596

• Add explicit mention to HDR being off

  coreh

  committed
  fae6dc6

• Move comment about clear color, rephrase it

  coreh

  committed
  28a9049

• Fix typo (“to the whatever” -> “to whatever”)

  coreh

  committed
  0b5fa68

• Fix markdown heading formatting

  coreh

  committed
  eeeca2c

• Add comment about order of specular transmission and alpha blending

  coreh

  committed
  33a672e

• Merge branch 'main' into transmission

  coreh

  committed
  7a14a28

• Update comment (“Best” -> “Better”)

  coreh

  committed
  2c09dc0

• Fix spacing

  coreh

  committed
  52f75f3

Commits on Oct 29, 2023

• Remove continue to ensure predictable control flow in for loop

  coreh

  committed
  3908cd6

• Remove DEPTH_PREPASS guard from show_prepass shader

  coreh

  committed
  ad7a892

Commits on Oct 31, 2023

• Fix overly dark environment map fallback for transmission with zero steps

  coreh

  committed
  98ef3e5

• Fix documentation link lint error

  coreh

  committed
  9d50dd1

• Merge branch 'main' into transmission

  coreh

  committed
  5dc4387