Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix doc_markdown lints in bevy_text #3482

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix doc_markdown lints in bevy_text #3482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e82d03e
Fix doc_markdown lints in bevy_text
mfdorst Dec 29, 2021
2d30ad4
Removed link to nonexistent `TextGlyphs` type
mfdorst Dec 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/bevy_text/src/text2d.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ pub struct QueuedText2d {
entities: Vec<Entity>,
}

/// Updates the TextGlyphs with the new computed glyphs from the layout
/// Updates the `TextGlyphs` with the new computed glyphs from the layout
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a type named TextGlyphs (or TextGlyph). Not sure if this documentation is outdated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also referenced at crates/bevy_ui/src/widget/text.rs:37

#[allow(clippy::too_many_arguments, clippy::type_complexity)]
pub fn text2d_system(
mut queued_text: Local<QueuedText2d>,
Expand Down