Add missing #[reflect(Component, Default)] to SceneRoot and DynamicSceneRoot.
#16816
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DynamicSceneRoot`. Someone forgot to add these, and I need them since I spawn these components in my [glXF] files. [glXF]: https://github.com/pcwalton/bevy-glxf-loader/
pcwalton
added
A-Reflection
mgi388
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
LGTM. Per https://github.com/bevyengine/bevy/pull/15231/files and its linked tracking issue, are there are some other ones e.g. Debug, PartialEq that are "meant" to be added as well?
bushrat011899
approved these changes
Dec 14, 2024
IQuick143
added
S-Ready-For-Final-Review
mgi388
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone forgot to add these, and I need them since I spawn these components in my glXF files.