Fix registering all reflection types that are components as reflection components #16800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BD103
added
C-Bug
MrGVSV
approved these changes
Dec 13, 2024
MrGVSV
added
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
Import merge conflict was a bit tricky; let's see if CI likes that. |
…erived using feature-flag checks (cfg_attr).
|
My code scanner had a bug where it missed #[cfg_attr(feature = "bevy_reflect", derive(Reflect), reflect(Debug))]since it only scanned for top-level derives. I found only two instances of the problem this PR fixes, both in the gamepad code. I also pushed the fix to my code scanner. |
|
Thanks for cleaning this up <3 Merging. |
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
…n components (bevyengine#16800) # Objective Fixes bevyengine#16659 ## Solution - I just added all the `#[reflect(Component)]` attributes where necessary. ## Testing I wrote a small program that scans the bevy code for all structs and enums that derive `Component` and `Reflect`, but don't have the attribute `#[reflect(Component)]`. I don't know if this testing program should be part of the testing suite of bevy. It takes a bit of time to scan the whole codebase. In any case, I've published it [here](https://github.com/anlumo/bevy-reflect-check). --------- Co-authored-by: Alice Cecile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #16659
Solution
#[reflect(Component)]attributes where necessary.Testing
I wrote a small program that scans the bevy code for all structs and enums that derive
ComponentandReflect, but don't have the attribute#[reflect(Component)].I don't know if this testing program should be part of the testing suite of bevy. It takes a bit of time to scan the whole codebase. In any case, I've published it here.