Code

Faster entity cloning#16717

Code

Merged

alice-i-cecile merged 46 commits intobevyengine:mainbevyengine/bevy:mainfrom eugineerd:entity_cloning_fastereugineerd/bevy:entity_cloning_fasterCopy head branch name to clipboardDec 18, 2024

+932-188

Commits

Commits on Dec 4, 2024

• add simple entity cloning benchmark

  eugineerd

  committed
  0b0ab27

  Copy full SHA for 0b0ab27

• first draft of faster cloning

  eugineerd

  committed
  6316f3c

  Copy full SHA for 6316f3c

Commits on Dec 7, 2024

• use bumpalo to store component data

  eugineerd

  committed
  d4ac17a

  Copy full SHA for d4ac17a

• add read_source_component_reflect

  eugineerd

  committed
  c710dff

  Copy full SHA for c710dff

• redesign ComponentCloneHandler

  eugineerd

  committed
  581d2d0

  Copy full SHA for 581d2d0

• clippy fixes

  eugineerd

  committed
  c65f20d

  Copy full SHA for c65f20d

• Merge remote-tracking branch 'upstream/main' into entity_cloning_faster

  eugineerd

  committed
  1e34bfa

  Copy full SHA for 1e34bfa

Commits on Dec 8, 2024

• implement fast entity cloning for reflect handler

  Show description for 676b7f2
  eugineerd

  committed
  676b7f2

  Copy full SHA for 676b7f2

• improve entity cloning benchmark

  eugineerd

  committed
  fd73075

  Copy full SHA for fd73075

• Merge branch 'entity_cloning_faster_reflect' into entity_cloning_faster

  eugineerd

  committed
  34f4d30

  Copy full SHA for 34f4d30

• clippy fixes

  eugineerd

  committed
  56e6ab2

  Copy full SHA for 56e6ab2

• fix doctests

  eugineerd

  committed
  b4f53d5

  Copy full SHA for b4f53d5

• actually fix doctests

  eugineerd

  committed
  8699057

  Copy full SHA for 8699057

• last doc fixes (hopefully)

  eugineerd

  committed
  4cf7e6e

  Copy full SHA for 4cf7e6e

Commits on Dec 10, 2024

• fix entity cloning using reflect tests to actually use correct handlers

  eugineerd

  committed
  8b6c9a1

  Copy full SHA for 8b6c9a1

• actually write pointers in write_target_component_reflect

  eugineerd

  committed
  3aefdaf

  Copy full SHA for 3aefdaf

• don't allow double write in write_target_component_reflect

  eugineerd

  committed
  81558c0

  Copy full SHA for 81558c0

• Merge remote-tracking branch 'upstream/main' into entity_cloning_faster

  eugineerd

  committed
  fbaefd8

  Copy full SHA for fbaefd8

• fix entity_cloning benchmark after rename

  eugineerd

  committed
  a9739a1

  Copy full SHA for a9739a1

Commits on Dec 16, 2024

• use ReflectFromReflect in component_clone_via_reflect fast path

  eugineerd

  committed
  588eba7

  Copy full SHA for 588eba7

• use default_handler instead of default for ComponentCloneHandler

  Show description for 5c7c42e
  eugineerd

  committed
  5c7c42e

  Copy full SHA for 5c7c42e

• Merge remote-tracking branch 'upstream/main' into entity_cloning_faster

  eugineerd

  committed
  41d5619

  Copy full SHA for 41d5619

• Add clarification for clone_fast and clone_slow in component_clone_via_reflect

  eugineerd

  committed
  7b41bf9

  Copy full SHA for 7b41bf9

• fix some post-merge weirdness

  eugineerd

  committed
  53ec75d

  Copy full SHA for 53ec75d

• Update crates/bevy_ecs/src/entity/clone_entities.rs

  Show description for cff4ba6
  

  eugineerd

  and

  alice-i-cecile

  authored
  cff4ba6

  Copy full SHA for cff4ba6

Commits on Dec 17, 2024

• add test to make sure reflect handler doesn't panic if component can't be cloned

  eugineerd

  committed
  9601364

  Copy full SHA for 9601364

• rewrite component_clone_via_reflect to not panic

  eugineerd

  committed
  56ff78d

  Copy full SHA for 56ff78d

• put all reflect tests in one module

  eugineerd

  committed
  fe31086

  Copy full SHA for fe31086

• Merge remote-tracking branch 'origin/entity_cloning_faster' into entity_cloning_faster

  eugineerd

  committed
  d484a9f

  Copy full SHA for d484a9f

• remove unused import in benchmark

  eugineerd

  committed
  52b1f26

  Copy full SHA for 52b1f26

• remove outdated comment

  eugineerd

  committed
  e86b963

  Copy full SHA for e86b963

Commits on Dec 18, 2024

• fix leak in component_clone_via_reflect's ReflectFromWorld path

  eugineerd

  committed
  2d11e57

  Copy full SHA for 2d11e57

• make read_source_component_reflect return None when ReflectFromPtr's TypeId does not match component's TypeId

  eugineerd

  committed
  7b0f45d

  Copy full SHA for 7b0f45d

• use debug_checked_unwrap for getting source component ptr

  Show description for 3cb6891
  eugineerd

  committed
  3cb6891

  Copy full SHA for 3cb6891

• use type_id() instead of reflect_type_info().type_id() in write_target_component_reflect

  eugineerd

  committed
  0de432d

  Copy full SHA for 0de432d

• store ComponentInfo in ComponentCloneCtx

  eugineerd

  committed
  ca17d74

  Copy full SHA for ca17d74

• use stored ComponentInfo instead of getting it from Components

  eugineerd

  committed
  3c70318

  Copy full SHA for 3c70318

• add write_target_component_ptr to allow writing component clone handlers for components without TypeId

  eugineerd

  committed
  05a307a

  Copy full SHA for 05a307a

• Merge remote-tracking branch 'upstream/main' into entity_cloning_faster

  eugineerd

  committed
  b15c917

  Copy full SHA for b15c917

• allow clone_fn in write_target_component_ptr to fail

  eugineerd

  committed
  6f03851

  Copy full SHA for 6f03851

• clippy

  eugineerd

  committed
  fbaa0cb

  Copy full SHA for fbaa0cb

• no_std

  eugineerd

  committed
  1ae0d0d

  Copy full SHA for 1ae0d0d

• Fix missed replacement of self.components with self.component_info inside ComponentCloneCtx

  Show description for a2a78d6
  

  eugineerd

  and

  chescock

  authored
  a2a78d6

  Copy full SHA for a2a78d6

• add TypeId check in ReflectFromWorld component clone path

  Show description for 35a1902
  

  eugineerd

  and

  chescock

  authored
  35a1902

  Copy full SHA for 35a1902

• fix getting wrong type_id

  eugineerd

  committed
  b02678d

  Copy full SHA for b02678d

• fix build without default features

  eugineerd

  committed
  4abf6b9

  Copy full SHA for 4abf6b9