picking: disable raycast backface culling for Mesh2d #16657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes raycast picking with lyon
aevyrie
approved these changes
Dec 5, 2024
Co-authored-by: Aevyrie <[email protected]>
IQuick143
added
D-Straightforward
IQuick143
approved these changes
Dec 5, 2024
tim-blackbird
added
C-Bug
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
# Objective The "mehses" typo introduced in a review comment [here](#16657 (comment)) hurts my soul, it was merged right as I was about to comment about it :( ## Solution Fix it :D (also, why didn't the CI typo checker catch this?)
mockersf
pushed a commit
that referenced
this pull request
Jan 3, 2025
# Objective - This fixes raycast picking with lyon - reverse winding of 2D meshes currently results in them being rendered but not pickable as the raycast passes through the backface and would only hit "from below" ## Solution - Disables backface culling for Mesh2d ## Testing - Tested picking with bevy_prototype_lyon - Could probably use testing with Mesh3d (should not be affected) and SimplifiedMesh (no experience with that, could have the same issue if used for 2D?) --------- Co-authored-by: Aevyrie <[email protected]>
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - This fixes raycast picking with lyon - reverse winding of 2D meshes currently results in them being rendered but not pickable as the raycast passes through the backface and would only hit "from below" ## Solution - Disables backface culling for Mesh2d ## Testing - Tested picking with bevy_prototype_lyon - Could probably use testing with Mesh3d (should not be affected) and SimplifiedMesh (no experience with that, could have the same issue if used for 2D?) --------- Co-authored-by: Aevyrie <[email protected]>
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective The "mehses" typo introduced in a review comment [here](bevyengine#16657 (comment)) hurts my soul, it was merged right as I was about to comment about it :( ## Solution Fix it :D (also, why didn't the CI typo checker catch this?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing